From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11F50CD3445 for ; Fri, 8 May 2026 21:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NuDyd+pdDE/YN+9KZpt+S8gMDx02yjwA/CK1DnFyXwo=; b=TUkcKITCdfeDsNUIHdKeD6DLWn fipTryhPvmLQvjpt/1LZwzynwjlkookDVW+gzlWROrGQg3fgd3ZJUcobVhcUiRxkY9uH8cW5ahLuu GiFeXUP1UpcMNps5h1XwtnD0U8yoF0QPoQwuVNdzA0A4xHvA9cufRKOZuelz1lVSS896rFAapQqPF XgimnisDG3YdtMLhG2Osc6zi+ZP7fyFQmxNyzmz2txSyhDoHDTMDeVQ3JwJZLrBC/BjDhldiI/vll /zM1ogqUkm7y+PsCYBI8GgSMuP4FJfs4EEbVr+rJV0VpSdlcwij5zdPqBo0d6/Cqmnwai6LdF+Z6d CLhAPkRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wLSaz-00000007X7z-2sG9; Fri, 08 May 2026 21:18:53 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wLSaw-00000007X6g-0Qom for linux-arm-kernel@lists.infradead.org; Fri, 08 May 2026 21:18:51 +0000 Received: by mail-qt1-x82b.google.com with SMTP id d75a77b69052e-50d876329bbso22315091cf.2 for ; Fri, 08 May 2026 14:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20251104.gappssmtp.com; s=20251104; t=1778275129; x=1778879929; darn=lists.infradead.org; h=mime-version:user-agent:autocrypt:references:in-reply-to:date:cc:to :from:subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=NuDyd+pdDE/YN+9KZpt+S8gMDx02yjwA/CK1DnFyXwo=; b=fbXEn+IZhvqJRgmzmmN3IAvQJgTL5j3QAu2JUkvDbwUjwHKeF/RByQxKT7yYkI2+Ng JgBKEFZ70hx9w/RSHVccTxiU7ZPkWB4Mjb6bJUPA7z0Xh2aUD9Vswb9sBQKJt36x+lN3 ++wioAH/fdUGIFP3muXfelbfbzm8RMHaEqJFO7fx+oZxdR/3jc4EZbKFihrSH2LzvyMY IiUpUZg2vV/1IRLuxnUh1A0P3m8w+9/rKCmEBGdvwMK0KtRc2FsP2pdEVPUzr+185W1u xqAb2O2Zaod6eJKdPM7PUO76Hmpz/u5gghxnkyNoM5xF4OzJh19w6IhqcX5XRYWB0+Gu 8Ljg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778275129; x=1778879929; h=mime-version:user-agent:autocrypt:references:in-reply-to:date:cc:to :from:subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NuDyd+pdDE/YN+9KZpt+S8gMDx02yjwA/CK1DnFyXwo=; b=BcQ4RpreuaYAF+cHeNItGVXKe5iMTWMc2YJEBzVpSGpKAIiLG58ZleqEbzxHCcMQy0 dG9CifurnCNbI0nEaLg5KX3x5GtRmQFpPhhftXV1ungFVKVSJFWbJyV22WHktFE9sP9Q m2MofQagPF1pdYtcRuvxKQJ2xTDEThAzThOTzORHzbzPcGluc4tP7ZuryoDxYb8Gb1Ww 3CsxRRImksAAPT9flTIDDi5K/RbtS6fPXUvQWBRWvL4D3HCK34cAlPOL4JIk7iEvTVlc ldFBMiO7POLvC2fBxh6bDnOvsibKrWUFvBEBU18p3VFKLFYgk3wsDY2Kiwr8lq8CVb7+ d83w== X-Forwarded-Encrypted: i=1; AFNElJ9L91VoewvgpFUSHsO+kcTNm3dMixuMlWXslUI5SdFo9ASPtn6/5Bi8xX7mdAKT4l4EMfhkj7q0yBJVkV7/EGM6@lists.infradead.org X-Gm-Message-State: AOJu0YytZhX9N0+PxDDa5MlRVah7xEn4DGxFZz83QHHSOy5fMtHdW6vM ZRhnBW9IWxV6q8Qgp493lWDjRjLxFwYOvidZ3k/AxzmRUYPBPFtGoJsdv9iXNwR0hv8= X-Gm-Gg: AeBDieubma/lK2oF4590D9m7Sk8E1en3BYB3ON0y6vIV47vc8hAlKJmRl9wO7qjHArb r5MiQFL1c0/aJ0Jv0K8XGHBdlxRjBf1Vnaiq946kNVypyIU5yMYsr0kB3WnVm3pNPcKO5h7QbBy qqz5EeqXTcnvDGTFd8RBFWqJZFI2DRuFDH4AxDLCC6dU1Xou4jMGKzCklRCL7wiqiPlwp/IEWsB MYWhqR23fgaZjxWZmlUPiiapQtc9KcNWXTr9s6NlZtetN/gh2KwAywHSwUS9S8w7gWqBJIsoh4Q DMpuB9DEG6Hs80PkV7g94imyPGasvLTuz/RM6XHX9ffWHB6NnKr8ElbQHxSFJBN5KXBBODsRb+z ea6mTjkEq6p8DDBZbyLNJej3kRyHFDqKiecz0sbdsTYjHREg6BtKdmCyQ+N6Cc32vpMg+bSTA44 lvFM3QKrMV15dRm1rw7ODIGsL17WvIO1+eV1qr7Ps= X-Received: by 2002:a05:622a:4d4e:b0:50b:5336:1d20 with SMTP id d75a77b69052e-514621d5127mr196554381cf.53.1778275128704; Fri, 08 May 2026 14:18:48 -0700 (PDT) Received: from ?IPv6:2606:6d00:15:e06b::c41? ([2606:6d00:15:e06b::c41]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8bf3b0c7600sm28019116d6.1.2026.05.08.14.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 14:18:47 -0700 (PDT) Message-ID: <4f5e481c8883b358ee4cef64f26f3f00f0ac7304.camel@ndufresne.ca> Subject: Re: [PATCH v5 12/29] media: rockchip: rga: avoid odd frame sizes for YUV formats From: Nicolas Dufresne To: Sven =?ISO-8859-1?Q?P=FCschel?= , Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, sebastian.reichel@collabora.com Date: Fri, 08 May 2026 17:18:46 -0400 In-Reply-To: <20260428-spu-rga3-v5-12-eb7f5d019d86@pengutronix.de> References: <20260428-spu-rga3-v5-0-eb7f5d019d86@pengutronix.de> <20260428-spu-rga3-v5-12-eb7f5d019d86@pengutronix.de> Autocrypt: addr=nicolas@ndufresne.ca; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-qZ2RVVDen/K+BWJk4jzk" User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260508_141850_200556_53330D28 X-CRM114-Status: GOOD ( 20.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --=-qZ2RVVDen/K+BWJk4jzk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le mardi 28 avril 2026 =C3=A0 11:00 +0200, Sven P=C3=BCschel a =C3=A9crit= =C2=A0: > Avoid odd frame sizes for YUV formats, as they may cause undefined > behavior. This is done in preparation for the RGA3, which hangs when the > output format is set to 129x129 pixel YUV420 SP (NV12). >=20 > This requirement is documented explicitly for the RGA3 in=C2=A0 section 5= .6.3 > of the RK3588 TRM Part 2. For the RGA2 the RK3588 TRM Part 2 > (section 6.1.2) and RK3568 TRM Part 2 (section 14.2) only mentions the > x/y offsets and stride aligning requirements. But the vendor driver for > the RGA2 also contains checks for the width and height to be aligned to > 2 bytes. >=20 > Signed-off-by: Sven P=C3=BCschel > --- > =C2=A0drivers/media/platform/rockchip/rga/rga.c | 19 ++++++++++++++----- > =C2=A01 file changed, 14 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/pl= atform/rockchip/rga/rga.c > index f599c992829dd..77b8c7ab74274 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -337,6 +337,19 @@ static int vidioc_try_fmt(struct file *file, void *p= riv, struct v4l2_format *f) > =C2=A0 struct rga_ctx *ctx =3D file_to_rga_ctx(file); > =C2=A0 const struct rga_hw *hw =3D ctx->rga->hw; > =C2=A0 struct rga_fmt *fmt; > + struct v4l2_frmsize_stepwise frmsize =3D { > + .min_width =3D hw->min_width, > + .max_width =3D hw->max_width, > + .min_height =3D hw->min_height, > + .max_height =3D hw->max_height, > + .step_width =3D 1, > + .step_height =3D 1, > + }; > + > + if (v4l2_is_format_yuv(v4l2_format_info(pix_fmt->pixelformat))) { > + frmsize.step_width =3D 2; > + frmsize.step_height =3D 2; I think its fine like this, so let's start with: Reviewed-by: Nicolas Dufresne But it does not feel like a hardware alignment to me. When we process in software these things, the minimum alignment is bound to the subsampling, s= ince there is no way to store half or quarter pixels, the padded width/height requires a step that follow the subsampling, something like: frmsize.step_width =3D finfo->hdiv; frmsize.step_height =3D finfo->vdiv; Nicolas > + } > =C2=A0 > =C2=A0 if (V4L2_TYPE_IS_CAPTURE(f->type)) { > =C2=A0 const struct rga_frame *frm; > @@ -358,11 +371,7 @@ static int vidioc_try_fmt(struct file *file, void *p= riv, struct v4l2_format *f) > =C2=A0 if (!fmt) > =C2=A0 fmt =3D &hw->formats[0]; > =C2=A0 > - pix_fmt->width =3D clamp(pix_fmt->width, > - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hw->min_width, hw->max_width); > - pix_fmt->height =3D clamp(pix_fmt->height, > - hw->min_height, hw->max_height); > - > + v4l2_apply_frmsize_constraints(&pix_fmt->width, &pix_fmt->height, &frms= ize); > =C2=A0 v4l2_fill_pixfmt_mp(pix_fmt, fmt->fourcc, pix_fmt->width, pix_fmt-= >height); > =C2=A0 pix_fmt->field =3D V4L2_FIELD_NONE; > =C2=A0 --=-qZ2RVVDen/K+BWJk4jzk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaf5TNgAKCRDZQZRRKWBy 9K22AP9NA5svkOS4YL++qXSzMq8kynIFrKCnDRWKeJx++AbT9AD/dLvKF5HRQ8Cf i9PlqWBZXkzVLS+1T8+GiOLpb3UFXAQ= =85ga -----END PGP SIGNATURE----- --=-qZ2RVVDen/K+BWJk4jzk--