From: geoff@infradead.org (Geoff Levand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] arm64: Split soft_restart into two stages
Date: Fri, 09 May 2014 00:48:17 +0000 [thread overview]
Message-ID: <4f77128335984c2678eda4e9db39d8bedfc77fab.1399594544.git.geoff@infradead.org> (raw)
In-Reply-To: <cover.1399594544.git.geoff@infradead.org>
Remove the call to setup_restart() from within soft_restart(), change
setup_restart() from local to global scope by removing its static attribute,
and add a function prototype for setup_restart() in system_misc.h.
Splitting setup_restart() and soft_restart() into two different operations
allows for the calling routine to call setup_restart(), then perform some
operation with the identity map in enabled, and then call soft_restart() to
disable the MMU and perform the soft reset. It is expected that the calling
routine will call setup_restart(), then shortly thereafter call soft_restart().
To properly manage the shutdown of spin-table secondary CPUs it is necessary to
transition those CPUs into a state compatible with booting.txt. The existing
implementation of soft_restart() did not allow for the transition to an
identity mapped spin loop.
Signed-off-by: Geoff Levand <geoff@infradead.org>
---
arch/arm64/include/asm/system_misc.h | 1 +
arch/arm64/kernel/process.c | 4 +---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/include/asm/system_misc.h b/arch/arm64/include/asm/system_misc.h
index 7a18fab..15bc824 100644
--- a/arch/arm64/include/asm/system_misc.h
+++ b/arch/arm64/include/asm/system_misc.h
@@ -41,6 +41,7 @@ struct mm_struct;
extern void show_pte(struct mm_struct *mm, unsigned long addr);
extern void __show_regs(struct pt_regs *);
+void setup_restart(void);
void soft_restart(unsigned long);
extern void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *cmd);
diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index 6391485..d52c660 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -50,7 +50,7 @@
#include <asm/processor.h>
#include <asm/stacktrace.h>
-static void setup_restart(void)
+void setup_restart(void)
{
/*
* Tell the mm system that we are going to reboot -
@@ -74,8 +74,6 @@ void soft_restart(unsigned long addr)
typedef void (*phys_reset_t)(unsigned long);
phys_reset_t phys_reset;
- setup_restart();
-
/* Switch to the identity mapping */
phys_reset = (phys_reset_t)virt_to_phys(cpu_reset);
phys_reset(addr);
--
1.9.1
next prev parent reply other threads:[~2014-05-09 0:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 0:48 [PATCH 0/8] arm64 kexec kernel patches Geoff Levand
2014-05-09 0:48 ` [PATCH 6/8] arm64/kexec: kexec needs cpu_die Geoff Levand
2014-05-09 8:24 ` Mark Rutland
2014-05-13 22:27 ` Geoff Levand
2014-05-09 0:48 ` [PATCH 7/8] arm64/kexec: Add core kexec support Geoff Levand
2014-05-09 15:36 ` Mark Rutland
2014-05-13 22:27 ` Geoff Levand
2014-05-16 10:26 ` Mark Rutland
2014-05-14 10:54 ` Catalin Marinas
2014-05-14 23:20 ` Geoff Levand
2014-07-07 7:33 ` Dave Young
2014-07-11 9:47 ` Dave Young
2014-05-09 0:48 ` [PATCH 8/8] arm64: Enable kexec in defconfig Geoff Levand
2014-05-09 0:48 ` [PATCH 3/8] arm64: Add spin-table cpu_die Geoff Levand
2014-05-09 8:54 ` Mark Rutland
2014-05-09 0:48 ` [PATCH 2/8] arm64: Make cpu_read_ops generic Geoff Levand
2014-05-09 0:48 ` Geoff Levand [this message]
2014-05-09 0:48 ` [PATCH 1/8] arm64: Use cpu_ops for smp_stop Geoff Levand
2014-05-09 8:44 ` Mark Rutland
2014-05-13 22:27 ` Geoff Levand
2014-05-09 0:48 ` [PATCH 4/8] arm64: Add smp_spin_table_set_die Geoff Levand
2014-05-09 16:22 ` [PATCH 0/8] arm64 kexec kernel patches Mark Rutland
2014-05-13 22:26 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f77128335984c2678eda4e9db39d8bedfc77fab.1399594544.git.geoff@infradead.org \
--to=geoff@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).