From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E666AC433EF for ; Tue, 1 Feb 2022 11:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AjPiEKyITmACGiw3cdl9CsG8SqbLCpyYr8QMcTEX8lo=; b=v0EB9OHZY4Z5KL CrPHDAatJfs1KG+0+foVJNMclcGRREyUQWWOyx+VtutX0kKd0t+Hhgtil+301zI4Zm/TqrkmWN6AC IqrAbujTYTe+i7NMaHMRKJ4bH6iyBNq6UYh+KqEcJ/fixrvXbdX/5Zf4sMXgn2qEdvTZZ7OQ2OBfV jfnDBbBobibn929xxrKkwvPH36uTombIL2ZRzmwAqIQEtVggB6Sqzz5v9zlYgOw/rgs/rs/25GWw+ YQIfRnfJjZJpEsElzc35Em2Orpx3jk2aNxOnLk25rnm9HWALYMQLrD0V18WPslnAEybd/hqcuKFND 0v7WdfhEIqqTEgy+zDWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEr3O-00BoCp-9n; Tue, 01 Feb 2022 11:10:30 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEr3K-00BoB6-09 for linux-arm-kernel@lists.infradead.org; Tue, 01 Feb 2022 11:10:27 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 21F7B81221; Tue, 1 Feb 2022 12:10:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1643713822; bh=4NxyB/iPq8vK/OmWYNhZGtIzuhTgDCFHMaXlwqjvY60=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qSDG1T4hcUzQpZl+ZP1Nd2+t46wbuuQDFAimeiri9UaiHohQJ0cOHOaBLQ9ROkRkK 2HiG1rGnOEMjIGb8imEWGAg37wNUNgZwYjmo5YgkREhPF7Wi7ssttJLbR1toT0RbEp H9HzNAz8AfgSq+JO/LIGnJQwobKR9Me2YaXhzI8uSUSdzI4m4Rit/tJ9Tsdv8RsNXv kWYRJYRad6CMaY9ro7w+RhvNaR36FwIHy+KRKNG49qX5L2/aG5+DGMUpILlHlz4stG idazeZtfyS7mDVCo8xTKKrcZFizJDinGxtMkZhOuxxnC8L4yAHpiqX4jO6AikZIzyO nlX3+NQ9EREfg== Message-ID: <4f7d2ec6-cde9-4adf-141d-4e4651371bae@denx.de> Date: Tue, 1 Feb 2022 12:10:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check() Content-Language: en-US To: Christoph Niedermaier , dri-devel@lists.freedesktop.org, Boris Brezillon Cc: Philipp Zabel , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org References: <20220201110358.3530-1-cniedermaier@dh-electronics.com> From: Marek Vasut In-Reply-To: <20220201110358.3530-1-cniedermaier@dh-electronics.com> X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_031026_402701_C97FF4BE X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/1/22 12:03, Christoph Niedermaier wrote: > If display timings were read from the devicetree using > of_get_display_timing() and pixelclk-active is defined > there, the flag DISPLAY_FLAGS_SYNC_POSEDGE/NEGEDGE is > automatically generated. Through the function > drm_bus_flags_from_videomode() e.g. called in the > panel-simple driver this flag got into the bus flags, > but then in imx_pd_bridge_atomic_check() the bus flag > check failed and will not initialize the display. The > original commit fe141cedc433 does not explain why this > check was introduced. So remove the bus flags check, > because it stops the initialization of the display with > valid bus flags. > > Fixes: fe141cedc433 ("drm/imx: pd: Use bus format/flags provided by the bridge when available") > Signed-off-by: Christoph Niedermaier > Cc: Marek Vasut > Cc: Philipp Zabel > Cc: David Airlie > Cc: Daniel Vetter > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: linux-arm-kernel@lists.infradead.org > To: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/imx/parallel-display.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c > index a8aba0141ce7..06cb1a59b9bc 100644 > --- a/drivers/gpu/drm/imx/parallel-display.c > +++ b/drivers/gpu/drm/imx/parallel-display.c > @@ -217,14 +217,6 @@ static int imx_pd_bridge_atomic_check(struct drm_bridge *bridge, > if (!imx_pd_format_supported(bus_fmt)) > return -EINVAL; > > - if (bus_flags & > - ~(DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_DE_HIGH | > - DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | > - DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE)) { > - dev_warn(imxpd->dev, "invalid bus_flags (%x)\n", bus_flags); > - return -EINVAL; > - } +CC Boris _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel