From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34758D3515E for ; Wed, 1 Apr 2026 08:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x9cQrOxYz7ANqWLpK8s/4dFrbHO3EJwgSydn5cobuaw=; b=WXqeiQbpmHgA7ze5BHGynEp7sg 3xiuR3mLpiFW9wS8fQBltj0SqeWPgA1emCjyd6aiN+td4eJit330T+y5gOOuF0sB3Spi9MKEFV7nD zvM3GT/3sCwkNWtdVVhOwDv2NZWbB9nxNwpoO7WaBWjBnpoqA7eKj/XvgxquOJCnjsLMJSVogZzPL c0Wju7ZSeEH3fWWfwpCO1xLqhUZOiFOvhYHPDaAj25PlgNSMPaL5Hs7Vv2PNBIF2vyoU4Jsun/ssH VVHXidpCxbGq44QgPzmb2yol68jJUVin2M1azHxN0BEG3nwCotz4xjAu3a+eFuYjX1QVjwEZWe4UH OKf+Vzsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w7rNK-0000000ELzz-0lAj; Wed, 01 Apr 2026 08:56:34 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w7rNJ-0000000ELzo-1HnB for linux-arm-kernel@bombadil.infradead.org; Wed, 01 Apr 2026 08:56:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=x9cQrOxYz7ANqWLpK8s/4dFrbHO3EJwgSydn5cobuaw=; b=nS/IuOQmxxKK5d8VVrQU8FT77l z2IeyVJ6RzLmmF2pRb8b+pL6qGJMy4svHr7ww0TFhZzFfdSwh8HsNWPzqXvyTxn5WqwcTfPCfxiOP y7Wcl83p0f3PuPEOLI51A2w/hrkB8MbymZhQOhpqn1Vq2Ch5pa9oGR44KbMwLNynAEuKeqHlv0CUO IinSEeGG68WJFGcDRkvdiX9z1Ire9oeSXNhh/sfSrvoA/ZcMYXCYNiI4UJpvaEQQCCq3woU3xZqOq DB15OFP73SzfcA541Oz+jOY7Ch/shd0UnKDGMRPodl4Rfh5zH7yTqHwdIWIhYYqIK6DpJrGMdbe7f AsaQhY5A==; Received: from sea.source.kernel.org ([172.234.252.31]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w7rNG-0000000HU1t-0L6G for linux-arm-kernel@lists.infradead.org; Wed, 01 Apr 2026 08:56:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 97312406AF; Wed, 1 Apr 2026 08:56:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7BBDC2BCB0; Wed, 1 Apr 2026 08:56:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775033788; bh=zsd4StJJpgnz61X6fecPxiaAT0NAe+LmXZ14g1VbrRc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AN98VB0dPc0UyriPLL9y4CXpUrGnFGo8/bfoNESxK4x13FDlYhxgv/HySMlR1HoMD CECYCLL5TdbdlTL9E8sSeLjIUUetWgxB/+QhEjsgXMVAYlVkcBkcRkRm3Dk9maMPUA U/OkNl8r5+2KseH+KrB+/nF/JKlkyAeKhlcOR2cn/ns7kpOMzGNfN471dyFVay6bBi onCZ3rRd2rMxjr3nRQY/ZxgqIF7nYOy9UZSYNmRK07L+eYKm/fg60T9UAGKoSw2Xyx OVlUaR9FpXgAkLCD9NjtUBc7gHCOGcRyAy9JBIaVNfYW5V4RI7//D0bfmZzWrgG3to aUTyXQMzHBSlQ== Message-ID: <4fbac876-ac41-4ab4-a1fd-0277e0d0ef20@kernel.org> Date: Wed, 1 Apr 2026 10:56:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [EXT] Re: [PATCH 1/2] dt-bindings: gpu: mali-valhall-csf: Document i.MX952 support To: Guangliu Ding , Liviu Dudau Cc: Daniel Almeida , Alice Ryhl , Boris Brezillon , Steven Price , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , Jiyu Yang References: <20260331-master-v1-0-65c8e318d462@nxp.com> <20260331-master-v1-1-65c8e318d462@nxp.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260401_095630_615124_B2F697D6 X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/04/2026 10:48, Guangliu Ding wrote: > Hi Liviu > > Thanks for your review. Please refer to my comments below: > >> On Tue, Mar 31, 2026 at 06:12:38PM +0800, Guangliu Ding wrote: >>> Add compatible string of Mali G310 GPU on i.MX952 board. >>> >>> Signed-off-by: Guangliu Ding >>> Reviewed-by: Jiyu Yang >>> --- >>> Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml >> b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml >>> index 8eccd4338a2b..6a10843a26e2 100644 >>> --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml >>> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml >>> @@ -20,6 +20,7 @@ properties: >>> - enum: >>> - mediatek,mt8196-mali >>> - nxp,imx95-mali # G310 >>> + - nxp,imx952-mali # G310 >> >> Can you explain why this is needed? Can it not be covered by the existing >> compatible? > > There are functional differences in GPU module (GPUMIX) between i.MX95 > and i.MX952. So they cannot be fully covered by a single existing compatible. > On i.MX952, The GPU clock is controlled by hardware GPU auto clock-gating > mechanism, while the GPU clock is managed explicitly by the driver on i.MX95. > Because of these behavioral differences, separate compatible strings > "nxp,imx95-mali" and "nxp,imx952-mali" are needed to allow the driver to handle > the two variants independently and to keep room for future divergence. That's pretty arguable statement considering there is no driver code using it, so basically this patchset admits openly devices are fully compatible. Best regards, Krzysztof