From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: mtk-pmic-wrap: make of_device_ids const.
Date: Wed, 2 Aug 2017 12:39:39 +0200 [thread overview]
Message-ID: <50025832-8a59-0f05-7be1-91a2d2c309e1@gmail.com> (raw)
In-Reply-To: <1498651806.6668.2.camel@mhfsdcap03>
On 06/28/2017 02:10 PM, chen.zhong wrote:
> Hi,
> On Wed, 2017-06-28 at 10:28 +0530, Arvind Yadav wrote:
>> of_device_ids are not supposed to change at runtime. All functions
>> working with of_device_ids provided by <linux/of.h> work with const
>> of_device_ids. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/soc/mediatek/mtk-pmic-wrap.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> index a5f1093..1205a671 100644
>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
>> @@ -1067,7 +1067,7 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id)
>> .init_soc_specific = pwrap_mt2701_init_soc_specific,
>> };
>>
>> -static struct pmic_wrapper_type pwrap_mt8135 = {
>> +static const struct pmic_wrapper_type pwrap_mt8135 = {
>> .regs = mt8135_regs,
>> .type = PWRAP_MT8135,
>> .arb_en_all = 0x1ff,
>> @@ -1079,7 +1079,7 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id)
>> .init_soc_specific = pwrap_mt8135_init_soc_specific,
>> };
>>
>> -static struct pmic_wrapper_type pwrap_mt8173 = {
>> +static const struct pmic_wrapper_type pwrap_mt8173 = {
>> .regs = mt8173_regs,
>> .type = PWRAP_MT8173,
>> .arb_en_all = 0x3f,
>> @@ -1091,7 +1091,7 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id)
>> .init_soc_specific = pwrap_mt8173_init_soc_specific,
>> };
>>
>> -static struct of_device_id of_pwrap_match_tbl[] = {
>> +static const struct of_device_id of_pwrap_match_tbl[] = {
>> {
>> .compatible = "mediatek,mt2701-pwrap",
>> .data = &pwrap_mt2701,
>
> Acked-by: Chen Zhong <chen.zhong@mediatek.com>
>
Applied to v4.13-next/soc
Thanks a lot,
Matthias
prev parent reply other threads:[~2017-08-02 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 4:58 [PATCH] soc: mtk-pmic-wrap: make of_device_ids const Arvind Yadav
2017-06-28 12:10 ` chen.zhong
2017-08-02 10:39 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50025832-8a59-0f05-7be1-91a2d2c309e1@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox