From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: convert asm/irqflags.h to use asm-generic/irqflags.h
Date: Mon, 16 Jul 2012 11:10:47 -0500 [thread overview]
Message-ID: <50043D07.7050608@gmail.com> (raw)
In-Reply-To: <5003B648.30802@gmail.com>
On 07/16/2012 01:35 AM, Hui Wang wrote:
> Rob Herring wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> By implmenting arch_local_irq_restore with constant flags, we can use
>> asm-generic/irqflags.h and remove some of the ARM version of irqflags.h.
>>
>>
> [...]
>> - : "r" (flags)
>> - : "memory", "cc");
>> -}
>> -
>> static inline int arch_irqs_disabled_flags(unsigned long flags)
>> {
>> return flags & PSR_I_BIT;
>> }
>> +#define arch_irqs_disabled_flags arch_irqs_disabled_flags
>> +
>>
> Why don't directly define arch_irqs_disabled_flags like that:
>
> #define arch_irqs_disabled_flags(flags) (flags & PSR_I_BIT)
In most cases, I think inlines are preferred as they have type checking.
Doesn't really matter to me.
Rob
>
>> +#include <asm-generic/irqflags.h>
>>
>> #endif
>> #endif
>>
>
next prev parent reply other threads:[~2012-07-16 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 3:53 [PATCH 0/3] Use more asm-generic headers Rob Herring
2012-07-16 3:53 ` [PATCH 1/3] ARM: use generic version of identical asm headers Rob Herring
2012-07-16 10:51 ` Arnd Bergmann
2012-07-16 15:37 ` Nicolas Pitre
2012-07-16 3:53 ` [PATCH 2/3] ARM: use asm-generic version of kmap_types.h Rob Herring
2012-07-16 9:18 ` Arnd Bergmann
2012-07-16 16:15 ` Rob Herring
2012-07-16 3:53 ` [PATCH 3/3] ARM: convert asm/irqflags.h to use asm-generic/irqflags.h Rob Herring
2012-07-16 6:35 ` Hui Wang
2012-07-16 16:10 ` Rob Herring [this message]
2012-07-17 1:42 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50043D07.7050608@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).