* SATA working on 370/XP, Ethernet next...
@ 2012-07-20 14:41 Andrew Lunn
2012-07-20 15:35 ` Ian Molton
2012-07-20 15:52 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Andrew Lunn @ 2012-07-20 14:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ian
Good to hear you got SATA working. What was wrong?
I'm interested in Ethernet. I assume it uses
drivers/net/ethernet/marvell/mv643xx_eth.c?
If so, your work should be applicable for all Orion devices, and i'm
happy to test on kirkwood.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* SATA working on 370/XP, Ethernet next...
2012-07-20 14:41 SATA working on 370/XP, Ethernet next Andrew Lunn
@ 2012-07-20 15:35 ` Ian Molton
2012-07-20 15:52 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Ian Molton @ 2012-07-20 15:35 UTC (permalink / raw)
To: linux-arm-kernel
On 20/07/12 15:41, Andrew Lunn wrote:
> Hi Ian
Hi!
Good to hear you got SATA working. What was wrong?
Window setup was wrong - mostly just the function setting it up simply
not getting called.
I suspect that this platform rather badly needs the clock stuff
implementing.
> I'm interested in Ethernet. I assume it uses
drivers/net/ethernet/marvell/mv643xx_eth.c?
AIUI, yes. I havent checked yet.
> If so, your work should be applicable for all Orion devices, and i'm
happy to test on kirkwood.
Cheers! :)
-Ian
^ permalink raw reply [flat|nested] 6+ messages in thread
* SATA working on 370/XP, Ethernet next...
2012-07-20 14:41 SATA working on 370/XP, Ethernet next Andrew Lunn
2012-07-20 15:35 ` Ian Molton
@ 2012-07-20 15:52 ` Thomas Petazzoni
2012-07-20 16:05 ` Ian Molton
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2012-07-20 15:52 UTC (permalink / raw)
To: linux-arm-kernel
Le Fri, 20 Jul 2012 16:41:33 +0200,
Andrew Lunn <andrew@lunn.ch> a ?crit :
> I'm interested in Ethernet. I assume it uses
> drivers/net/ethernet/marvell/mv643xx_eth.c?
No, the network IP in the A370 and AXP is totally different and Marvell
engineers think it needs a new driver, and I have been making internal
reviews of their driver, but it needs more work before being ready for
submission.
A while ago, we had a discussion with Ben Dooks (from CodeThink) on
whether a new driver was needed or not. Ben will correct me if I'm
wrong, but he was suggesting that a new driver was not needed, but both
Marvell engineers and my comparison of the datasheets between A370/AXP
and older Marvell EBU SoCs clearly show that this IP has changed
dramatically, and is even not the same IP as before.
If needed, I can post the network driver code in a RFC state, but it is
clearly not yet ready for inclusion.
I would of course be happy to test SATA patches for the Armada XP. Ian,
did you reuse the plat-orion/addr-map.c code to do the window setup?
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* SATA working on 370/XP, Ethernet next...
2012-07-20 15:52 ` Thomas Petazzoni
@ 2012-07-20 16:05 ` Ian Molton
2012-07-20 16:12 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Ian Molton @ 2012-07-20 16:05 UTC (permalink / raw)
To: linux-arm-kernel
On 20/07/12 16:52, Thomas Petazzoni wrote:
> Le Fri, 20 Jul 2012 16:41:33 +0200,
> Andrew Lunn <andrew@lunn.ch> a ?crit :
>
> > I'm interested in Ethernet. I assume it uses
> > drivers/net/ethernet/marvell/mv643xx_eth.c?
>
> A while ago, we had a discussion with Ben Dooks (from CodeThink) on
> whether a new driver was needed or not. Ben will correct me if I'm
> wrong, but he was suggesting that a new driver was not needed, but both
> Marvell engineers and my comparison of the datasheets between A370/AXP
> and older Marvell EBU SoCs clearly show that this IP has changed
> dramatically, and is even not the same IP as before.
> If needed, I can post the network driver code in a RFC state, but it
> is clearly not yet ready for inclusion.
I would certainly like to see that if possible, it'd definitley help my
analysis of the problem.
> I would of course be happy to test SATA patches for the Armada XP.
> Ian, did you reuse the plat-orion/addr-map.c code to do the window
> setup? Best regards, Thomas
The code is very similar, and could probably be merged with that. is
plat-orion meant to now be common to orion, kirkwood, and armada?
the window setup code looks horrid to me - we really should look for a
way to pass this in nicely.
^ permalink raw reply [flat|nested] 6+ messages in thread
* SATA working on 370/XP, Ethernet next...
2012-07-20 16:05 ` Ian Molton
@ 2012-07-20 16:12 ` Thomas Petazzoni
2012-07-20 16:25 ` Ian Molton
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2012-07-20 16:12 UTC (permalink / raw)
To: linux-arm-kernel
Le Fri, 20 Jul 2012 17:05:26 +0100,
Ian Molton <ian.molton@codethink.co.uk> a ?crit :
> > A while ago, we had a discussion with Ben Dooks (from CodeThink) on
> > whether a new driver was needed or not. Ben will correct me if I'm
> > wrong, but he was suggesting that a new driver was not needed, but both
> > Marvell engineers and my comparison of the datasheets between A370/AXP
> > and older Marvell EBU SoCs clearly show that this IP has changed
> > dramatically, and is even not the same IP as before.
> > If needed, I can post the network driver code in a RFC state, but it
> > is clearly not yet ready for inclusion.
>
> I would certainly like to see that if possible, it'd definitley help my
> analysis of the problem.
Ok. I am not sure I wanted to submit this publicly on the netdev
mailing list right now, because the first feeling with a given patch
set is an important one. Would a private submission be possible?
I have been busy the last two days reviewing the code, making many
cleanups on it and collecting comments for the Marvell engineer who
wrote the code initially.
> > I would of course be happy to test SATA patches for the Armada XP.
> > Ian, did you reuse the plat-orion/addr-map.c code to do the window
> > setup? Best regards, Thomas
>
> The code is very similar, and could probably be merged with that. is
> plat-orion meant to now be common to orion, kirkwood, and armada?
Ok, so you duplicated the addr-map.c code?
Initially, I didn't want to use the plat-orion/ code, because I wanted
to replace that with proper drivers (i.e pinctrl driver instead of MPP,
gpio driver in drivers/gpio, proper platform driver for PCI, etc.). But
many drivers (SATA, SDIO, etc.) need the headers file from plat-orion/.
So reusing those drivers without using plat-orion/ is not that simple.
Would you mind sharing the current state of your SATA work, even if not
ready for prime time?
> the window setup code looks horrid to me - we really should look for a
> way to pass this in nicely.
I had started a discussion with Andrew on the mailing list earlier this
week, and we agreed for the moment to re-use the existing code, and see
later what could be done to expose this in the device tree.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* SATA working on 370/XP, Ethernet next...
2012-07-20 16:12 ` Thomas Petazzoni
@ 2012-07-20 16:25 ` Ian Molton
0 siblings, 0 replies; 6+ messages in thread
From: Ian Molton @ 2012-07-20 16:25 UTC (permalink / raw)
To: linux-arm-kernel
On 20/07/12 17:12, Thomas Petazzoni wrote:
> Le Fri, 20 Jul 2012 17:05:26 +0100, Ian Molton
> <ian.molton@codethink.co.uk> a ?crit :
>
>>> A while ago, we had a discussion with Ben Dooks (from CodeThink)
>>> on whether a new driver was needed or not. Ben will correct me if
>>> I'm wrong, but he was suggesting that a new driver was not
>>> needed, but both Marvell engineers and my comparison of the
>>> datasheets between A370/AXP and older Marvell EBU SoCs clearly
>>> show that this IP has changed dramatically, and is even not the
>>> same IP as before. If needed, I can post the network driver code
>>> in a RFC state, but it is clearly not yet ready for inclusion.
>>
>> I would certainly like to see that if possible, it'd definitley
>> help my analysis of the problem.
>
> Ok. I am not sure I wanted to submit this publicly on the netdev
> mailing list right now, because the first feeling with a given patch
> set is an important one. Would a private submission be possible?
Certainly.
>> The code is very similar, and could probably be merged with that.
>> is plat-orion meant to now be common to orion, kirkwood, and
>> armada?
>
> Ok, so you duplicated the addr-map.c code?
For now, yes. Since it sounds like it'll be acceptable to use plat-orion,
I will redo my patch to do that, and post it here.
> Initially, I didn't want to use the plat-orion/ code, because I
> wanted to replace that with proper drivers (i.e pinctrl driver
> instead of MPP, gpio driver in drivers/gpio, proper platform driver
> for PCI, etc.). But many drivers (SATA, SDIO, etc.) need the headers
> file from plat-orion/. So reusing those drivers without using
> plat-orion/ is not that simple.
Looks like a couple of base addresses differ. I'll let you know if this
causes any trouble on monday.
> Would you mind sharing the current state of your SATA work, even if
> not ready for prime time?
Sure, I'll sort out posting it up first thing monday.
>> the window setup code looks horrid to me - we really should look
>> for a way to pass this in nicely.
>
> I had started a discussion with Andrew on the mailing list earlier
> this week, and we agreed for the moment to re-use the existing code,
> and see later what could be done to expose this in the device tree.
I'll take a look.
Cheers,
-Ian
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-20 16:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-20 14:41 SATA working on 370/XP, Ethernet next Andrew Lunn
2012-07-20 15:35 ` Ian Molton
2012-07-20 15:52 ` Thomas Petazzoni
2012-07-20 16:05 ` Ian Molton
2012-07-20 16:12 ` Thomas Petazzoni
2012-07-20 16:25 ` Ian Molton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).