From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: davinci: remove rtc kicker release
Date: Tue, 24 Jul 2012 15:11:16 +0400 [thread overview]
Message-ID: <500E82D4.9090702@mvista.com> (raw)
In-Reply-To: <f9e348c8cb7402b27b1a5633b06620266e369641.1343046707.git.afzal@ti.com>
Hello.
On 23-07-2012 17:42, Afzal Mohammed wrote:
> rtc-omap driver is now capable of handling kicker mechanism,
> hence remove kicker handling at platform level, instead
> provide proper device name so that driver can handle kicker
> mechanism by itself
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> ---
> arch/arm/mach-davinci/devices-da8xx.c | 13 +------------
> 1 files changed, 1 insertions(+), 12 deletions(-)
> diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c
> index d1624a3..c915bff 100644
> --- a/arch/arm/mach-davinci/devices-da8xx.c
> +++ b/arch/arm/mach-davinci/devices-da8xx.c
> @@ -679,7 +679,7 @@ static struct resource da8xx_rtc_resources[] = {
> };
>
> static struct platform_device da8xx_rtc_device = {
> - .name = "omap_rtc",
> + .name = "am1808-rtc",
Why not "da8xx-rtc". Kick registers exist startting with
DA830/OMAP-L137/AM1707, not only on AM1808.
> .id = -1,
> .num_resources = ARRAY_SIZE(da8xx_rtc_resources),
> .resource = da8xx_rtc_resources,
> @@ -688,17 +688,6 @@ static struct platform_device da8xx_rtc_device = {
> int da8xx_register_rtc(void)
> {
> int ret;
> - void __iomem *base;
> -
> - base = ioremap(DA8XX_RTC_BASE, SZ_4K);
> - if (WARN_ON(!base))
> - return -ENOMEM;
> -
> - /* Unlock the rtc's registers */
> - __raw_writel(0x83e70b13, base + 0x6c);
> - __raw_writel(0x95a4f1e0, base + 0x70);
> -
> - iounmap(base);
>
> ret = platform_device_register(&da8xx_rtc_device);
> if (!ret)
WBR, Sergei
next parent reply other threads:[~2012-07-24 11:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1343046707.git.afzal@ti.com>
[not found] ` <f9e348c8cb7402b27b1a5633b06620266e369641.1343046707.git.afzal@ti.com>
2012-07-24 11:11 ` Sergei Shtylyov [this message]
2012-07-24 12:04 ` [PATCH 2/6] ARM: davinci: remove rtc kicker release Mohammed, Afzal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500E82D4.9090702@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox