From: ian.molton@codethink.co.uk (Ian Molton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] csb1724: Enable device tree based mv643xx ethernet support.
Date: Mon, 30 Jul 2012 17:57:37 +0100 [thread overview]
Message-ID: <5016BD01.9030508@codethink.co.uk> (raw)
In-Reply-To: <20120730161743.GN18016@lunn.ch>
On 30/07/12 17:17, Andrew Lunn wrote:
> Hi Ian
>
> Shouldn't there be two interrupt here?
>
> 292 orion_ge00_init(eth_data, 293
> GE00_PHYS_BASE, IRQ_KIRKWOOD_GE00_SUM, 294
> IRQ_KIRKWOOD_GE00_ERR);
No. This is thanks to the horrific mess in the mv643xx driver - its got
two drivers in one source file, and they do horrid things like pass
round base addresses.
Im making an effort to try to split them out into seperate mdio and
MAC/PHY drivers.
This is a start. :)
-Ian
next prev parent reply other threads:[~2012-07-30 16:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 15:15 [PATCH 0/6] mv643xx Ethernet DT support and CSB1724 board support Ian Molton
2012-07-30 15:15 ` [PATCH 1/6] Initial csb1724 board support (FDT) Ian Molton
2012-07-30 15:28 ` Andrew Lunn
2012-07-30 16:28 ` Ian Molton
2012-07-31 11:27 ` Arnd Bergmann
2012-07-30 15:15 ` [PATCH 2/6] mv643xx.c: Remove magic numbers Ian Molton
2012-07-30 15:15 ` [PATCH 3/6] mv643xx.c: Add basic device tree support Ian Molton
2012-07-30 15:39 ` Andrew Lunn
2012-07-30 16:49 ` Ian Molton
2012-07-30 16:19 ` Amar Nath
2012-07-30 16:32 ` Ian Molton
2012-07-31 15:12 ` Florian Fainelli
2012-07-31 7:14 ` Arnaud Patard (Rtp)
2012-07-31 8:19 ` Ian Molton
2012-07-31 8:27 ` Andrew Lunn
2012-07-31 8:45 ` Ian Molton
2012-07-31 8:58 ` Arnaud Patard (Rtp)
2012-07-31 9:14 ` Ian Molton
2012-07-31 14:30 ` Ben Dooks
2012-07-31 15:04 ` Arnaud Patard (Rtp)
2012-07-30 15:15 ` [PATCH 4/6] kirkwood: setup clock only in eth helpers Ian Molton
2012-07-30 16:12 ` Andrew Lunn
2012-07-30 16:52 ` Ian Molton
2012-07-30 19:10 ` Andrew Lunn
2012-07-30 16:46 ` Josh Coombs
2012-07-31 8:23 ` Ian Molton
2012-07-31 11:04 ` Ian Molton
2012-07-31 11:08 ` Andrew Lunn
2012-07-31 11:39 ` Ian Molton
2012-07-30 15:15 ` [PATCH 5/6] csb1724: Enable device tree based mv643xx ethernet support Ian Molton
2012-07-30 15:55 ` Andrew Lunn
2012-07-30 16:58 ` Ian Molton
2012-07-30 16:17 ` Andrew Lunn
2012-07-30 16:57 ` Ian Molton [this message]
2012-07-30 15:15 ` [PATCH 6/6] DT: Convert all kirkwood boards with mv643xx that use DT Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5016BD01.9030508@codethink.co.uk \
--to=ian.molton@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).