From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BAD2C54FB3 for ; Mon, 2 Jun 2025 14:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B52/43dJXMkQQpbPKyUY4ll+o7hNau/O7LBggGmj6XI=; b=1HRStvZ9dXzaagwaluBgEwbzDn q1DIOJfZHziq8b/ytjwP+wwG53Fbc+VhPdCbtJQUJqL2mRhT4gKpFV77bLOxr9q3WWKSMYIYg0Q88 8yfIrjMX4Lcqua8JYHRCJvfWTgg1GTv0Lrwvq29u2EH9OgIeOty1VEvzWn6qCfgz1tZ8s0DLwtLBK UmJCSVStdEOAMDg78Et9UiLEROX7rrf5+TAJrSferG+3QKzD3/23XwYXPuEJiFbI2hc+uN8LhYnKG y7aOyZG40Uc7xKxVcBL57CqCOcLfTtK9Et6zfRBuIwgdFWJKPICaCsZSjOXPwerA6ZwlaxMe9f/K2 9jrgvUCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uM6CC-00000007dTH-2fcf; Mon, 02 Jun 2025 14:31:24 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uM69z-00000007dF9-3kD4 for linux-arm-kernel@lists.infradead.org; Mon, 02 Jun 2025 14:29:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1748874547; x=1780410547; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=B52/43dJXMkQQpbPKyUY4ll+o7hNau/O7LBggGmj6XI=; b=Mwmi7xgSN4Mdb0WqT7pHcjmg8wiJxcYBwiVab7Zum83ITJscXsv7vOr+ dr94JiEMMaokdJt26I9w7y82gO1XQ3c9YmLUZx0tiWlFq1VH4V0Obb2kY NERS9TiJHb/fRh8DJcCbGD5vCB4Kni62ga8bdwJrKTiZV/cUSf0zJUybX wAtaeZ+WfQGUJ/sl8zcrSJ3RVh19FMkdHxNEkPlTwerfS0Yvuv3s9XwnG 9E/P0j3DDQQx4MlI9nBZeSMXRr0i2AxIo7kV69KbTcjgfhykPwuyyH3UB OE+cXyjPOwzDTtP8iURtgbV0/kRy0iUKcKOvY8sUD5XW0M7CJXkaHcnQS Q==; X-CSE-ConnectionGUID: ZWVTTkzFSzy6NUvHswA9fQ== X-CSE-MsgGUID: E8RWZSoVSa2M3OxK+K3hDw== X-IronPort-AV: E=Sophos;i="6.16,203,1744063200"; d="scan'208";a="44403954" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 02 Jun 2025 16:29:02 +0200 X-CheckPoint: {683DB52E-C-BA2A3BBA-F71352A8} X-MAIL-CPID: 1D59A8A4AC5FBF65F5124298CFB95C0D_5 X-Control-Analysis: str=0001.0A006377.683DB535.0013,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3A47F16B352; Mon, 2 Jun 2025 16:28:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1748874538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B52/43dJXMkQQpbPKyUY4ll+o7hNau/O7LBggGmj6XI=; b=r2BWx4PoEvzhhX9uMKZGYVgt+weGtIL8pmNl6IIcDO2m+t4J5X+NUzv3cBNw1jwHqrSuzd xULAg7Fhuaxk4XF9wIUiLWG/+Yn1+6y7wxz+ZUoEjFAqlJYNcz+ZUAztRWIploRY3SHr3s x1y6xP7grntWDuIXwNBpE6TL9OAYwcpSgZ1GrKBXj7ExovdtWuUAT9hHhxQ7y/7Xo4GFhz XG5QTg5EyPU8/Kt+c1GYH0EJok4AVIEasBhxdB2zp793hBGVtbEXmDbqn4bTF6f4lfoxch 6NlRakZLOiu/mRYnR5AorgChx206NQWcacs2/Id7r/KOLHkp3ZOZjTXXAGRkKg== From: Alexander Stein To: Frank Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Gregor Herburger , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com Subject: Re: [PATCH 2/2] arm64: dts: ls1028a: Add mbls1028a and mbls1028a-ind devicetrees Date: Mon, 02 Jun 2025 16:28:55 +0200 Message-ID: <5019298.31r3eYUQgx@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20250527060400.1005757-1-alexander.stein@ew.tq-group.com> <7298658.31r3eYUQgx@steina-w> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250602_072908_418710_74E05AC3 X-CRM114-Status: GOOD ( 20.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 30. Mai 2025, 18:17:00 CEST schrieb Frank Li: > ******************** > Achtung externe E-Mail: =D6ffnen Sie Anh=E4nge und Links nur, wenn Sie wi= ssen, dass diese aus einer sicheren Quelle stammen und sicher sind. Leiten = Sie die E-Mail im Zweifelsfall zur Pr=FCfung an den IT-Helpdesk weiter. > Attention external email: Open attachments and links only if you know tha= t they are from a secure source and are safe. In doubt forward the email to= the IT-Helpdesk to check it. > ******************** >=20 > On Fri, May 30, 2025 at 08:29:27AM +0200, Alexander Stein wrote: > > Hi Frank, > > > > Am Mittwoch, 28. Mai 2025, 17:35:52 CEST schrieb Frank Li: > > > On Tue, May 27, 2025 at 08:03:55AM +0200, Alexander Stein wrote: > > > > From: Gregor Herburger > > > > > > > > Add device trees for the MBLS1028A and the MBLS1028A-IND and the SoM > > > > TQMLS1028A. > > > > > > > > Signed-off-by: Gregor Herburger > > > > Signed-off-by: Alexander Stein > > > > --- > > > > arch/arm64/boot/dts/freescale/Makefile | 2 + > > > > .../fsl-ls1028a-tqmls1028a-mbls1028a-ind.dts | 68 ++++ > > > > .../fsl-ls1028a-tqmls1028a-mbls1028a.dts | 118 +++++++ > > > > .../fsl-ls1028a-tqmls1028a-mbls1028a.dtsi | 291 ++++++++++++++= ++++ > > > > .../dts/freescale/fsl-ls1028a-tqmls1028a.dtsi | 117 +++++++ > > > > > > New dts file, suggest run https://github.com/lznuaa/dt-format to nice= order > > > > Thanks for the suggestions. It does some improvements, but I also disag= ree > > with a lot of proposed changes: > > * Wrong indent of SPDX tag > > * model property should come first IMHO > > * {gpio,interrupt}-controller should come before #{gpio,interrupt}-cells >=20 > I checked code, it is specific rule to make -cells before -controller. It > should come from previous review comments. >=20 > Do you have document or mail list require -controller before --cells ? There is Documentation/devicetree/bindings/interrupt-controller/interrupts.= txt. While not exactly saying anything about property order, "interrupt-controll= er" is stated in the very first sentence. Also from a readers perspective having "-controller" first seems reasonable, IMHO. "-cells" is necessary because it is a controller. Best regards Alexander > Frank >=20 > > * gpio-hog property should come first in a hog node > > * sorting gpio-hog nodes by name instead of line number seems wrong > > > > There are some more bogus changes, so I'll skip this tool for now. > > > > Thanks & best regards > > Alexander > > > > > Frank > > > [...] > > -- > > TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany > > Amtsgericht M=FCnchen, HRB 105018 > > Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider > > http://www.tq-group.com/ > > > > >=20 >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/