From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mm: cpu_fa526_do_idle: remove WFI
Date: Mon, 17 Jun 2013 16:14:03 +0200 [thread overview]
Message-ID: <5020304.hteFFmWh1u@wuerfel> (raw)
In-Reply-To: <1371476360-8751-1-git-send-email-jonas.jensen@gmail.com>
On Monday 17 June 2013 15:39:20 Jonas Jensen wrote:
> As it was already suggested by Russell King and Arnd Bergmann ( https://lkml.org/lkml/2013/5/16/133 ), moxart and gemini seem to be the only platforms using CPU_FA526, and instead of pointing arm_pm_idle to an empty function from platform code, it makes sense to remove WFI code from the processor specific idle function.
>
> Note: moxart boots and prints to UART without this patch, but input is broken.
Please make sure you have proper line wraps. Lines in checkin
comments should be no longer than 70 characters normally.
> Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Since this patch is independent from the actual platform support,
it should go through Russell's patch tracker at
http://www.arm.linux.org.uk/developer/patches/
> arch/arm/mm/proc-fa526.S | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mm/proc-fa526.S b/arch/arm/mm/proc-fa526.S
> index d217e97..85280b1 100644
> --- a/arch/arm/mm/proc-fa526.S
> +++ b/arch/arm/mm/proc-fa526.S
> @@ -81,9 +81,7 @@ ENDPROC(cpu_fa526_reset)
> */
> .align 4
> ENTRY(cpu_fa526_do_idle)
> - mcr p15, 0, r0, c7, c0, 4 @ Wait for interrupt
> - mov pc, lr
> -
> + nop
>
> ENTRY(cpu_fa526_dcache_clean_area)
> 1: mcr p15, 0, r0, c7, c10, 1 @ clean D entry
Adding Imre and Florian to Cc for Gemini. They might have a comment
about this. I think we should delete arch/arm/mach-gemini/idle.c
after this as well.
Arnd
next prev parent reply other threads:[~2013-06-17 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 13:39 [PATCH] ARM: mm: cpu_fa526_do_idle: remove WFI Jonas Jensen
2013-06-17 14:14 ` Arnd Bergmann [this message]
2013-06-17 14:30 ` Russell King - ARM Linux
2013-06-17 14:58 ` Jonas Jensen
2013-06-17 15:01 ` Arnd Bergmann
2013-06-17 15:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5020304.hteFFmWh1u@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox