From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 17 Jun 2013 16:14:03 +0200 Subject: [PATCH] ARM: mm: cpu_fa526_do_idle: remove WFI In-Reply-To: <1371476360-8751-1-git-send-email-jonas.jensen@gmail.com> References: <1371476360-8751-1-git-send-email-jonas.jensen@gmail.com> Message-ID: <5020304.hteFFmWh1u@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 17 June 2013 15:39:20 Jonas Jensen wrote: > As it was already suggested by Russell King and Arnd Bergmann ( https://lkml.org/lkml/2013/5/16/133 ), moxart and gemini seem to be the only platforms using CPU_FA526, and instead of pointing arm_pm_idle to an empty function from platform code, it makes sense to remove WFI code from the processor specific idle function. > > Note: moxart boots and prints to UART without this patch, but input is broken. Please make sure you have proper line wraps. Lines in checkin comments should be no longer than 70 characters normally. > Signed-off-by: Jonas Jensen Acked-by: Arnd Bergmann Since this patch is independent from the actual platform support, it should go through Russell's patch tracker at http://www.arm.linux.org.uk/developer/patches/ > arch/arm/mm/proc-fa526.S | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mm/proc-fa526.S b/arch/arm/mm/proc-fa526.S > index d217e97..85280b1 100644 > --- a/arch/arm/mm/proc-fa526.S > +++ b/arch/arm/mm/proc-fa526.S > @@ -81,9 +81,7 @@ ENDPROC(cpu_fa526_reset) > */ > .align 4 > ENTRY(cpu_fa526_do_idle) > - mcr p15, 0, r0, c7, c0, 4 @ Wait for interrupt > - mov pc, lr > - > + nop > > ENTRY(cpu_fa526_dcache_clean_area) > 1: mcr p15, 0, r0, c7, c10, 1 @ clean D entry Adding Imre and Florian to Cc for Gemini. They might have a comment about this. I think we should delete arch/arm/mach-gemini/idle.c after this as well. Arnd