[PATCH 0/2] Fixes for PineNote DT validation issues

[PATCH 0/2] Fixes for PineNote DT validation issues

[Diederik de Haas]

These patches fix the following DeviceTree validation issues on the
PineNote dtb files:

    Warning (graph_child_address): /i2c@fe5c0000/tcpc@60/connector/ports:
      graph node has single child node 'port@0', #address-cells/#size-cells
      are not necessary

    usb2phy@fe8a0000 (rockchip,rk3568-usb2phy): otg-port: 'port' does not
      match any of the regexes: '^pinctrl-[0-9]+$'

And with these 2 fixes, there are no more DT validation issues :-)

The fix for the 2nd issue also fix these kernel errors:

  rockchip-usb2phy fe8a0000.usb2phy: Failed to create device link (0x180) with supplier port0 for /usb2phy@fe8a0000/otg-port
  rockchip-usb2phy fe8a0000.usb2phy: Failed to create device link (0x180) with supplier 3-0060 for /usb2phy@fe8a0000/otg-port

Cheers,
  Diederik

Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
---
Diederik de Haas (2):
      arm64: dts: rockchip: Simplify usb-c-connector port on rk3566-pinenote
      arm64: dts: rockchip: Move otg-port to controller on rk3566-pinenote

 arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 27 +++++++++--------------
 1 file changed, 10 insertions(+), 17 deletions(-)
---
base-commit: 6146a0f1dfae5d37442a9ddcba012add260bceb0
change-id: 20251109-rk3566-pinenote-dt-fixes-upstream-1fb32eff43ea

Best regards,
-- 
Diederik de Haas <diederik@cknow-tech.com>

[PATCH 1/2] arm64: dts: rockchip: Simplify usb-c-connector port on rk3566-pinenote

[Diederik de Haas]

The USB-C connector on the PineNote has only 1 port, so there's no need
for a 'ports' node with address-/size-cells properties as a single
'port' node suffices.

This fixes the following DT validation issue:

  Warning (graph_child_address): /i2c@fe5c0000/tcpc@60/connector/ports:
    graph node has single child node 'port@0',
    #address-cells/#size-cells are not necessary

Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
index 5c6f8cc401c9..7c65fe4900be 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
@@ -485,16 +485,9 @@ connector {
 			typec-power-opmode = "default";
 			pd-disable;
 
-			ports {
-				#address-cells = <0x1>;
-				#size-cells = <0x0>;
-
-				port@0 {
-					reg = <0x0>;
-
-					typec_hs_usb2phy0: endpoint {
-						remote-endpoint = <&usb2phy0_typec_hs>;
-					};
+			port {
+				typec_hs_usb2phy0: endpoint {
+					remote-endpoint = <&usb2phy0_typec_hs>;
 				};
 			};
 		};

-- 
2.51.0

[PATCH 2/2] arm64: dts: rockchip: Move otg-port to controller on rk3566-pinenote

[Diederik de Haas]

The 'rockchip,inno-usb2phy' binding's otg-port node does not have a port
node, so the current definition causes this DT validation issue:

  usb2phy@fe8a0000 (rockchip,rk3568-usb2phy): otg-port:
    'port' does not match any of the regexes: '^pinctrl-[0-9]+$'

Its purpose was to define the other endpoint for the USB-C connector
port. The 'snps,dwc3-common.yaml' DT binding does have a port node to
connect the dwc3 to type C connector with the 'usb-role-switch'
property. Therefore move the port node to the dwc3 node and add the
'usb-role-switch' property to it.
This fixes the above mention DT validation issue.

The incorrect definition also caused these kernel errors:

  rockchip-usb2phy fe8a0000.usb2phy: Failed to create device link (0x180) with supplier port0 for /usb2phy@fe8a0000/otg-port
  rockchip-usb2phy fe8a0000.usb2phy: Failed to create device link (0x180) with supplier 3-0060 for /usb2phy@fe8a0000/otg-port

With the changed definition, those errors are now also gone.

While at it, remove the 'dr_mode' property as that's already defined in
rk356x-base.dtsi and there's no point in redefining it.

Fixes: 87a267b4af09 ("arm64: dts: rockchip: Add USB and TCPC to rk3566-pinenote")
Cc: stable@vger.kernel.org
Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
---
 arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
index 7c65fe4900be..be8076a8e30c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
@@ -694,8 +694,14 @@ &uart2 {
 };
 
 &usb_host0_xhci {
-	dr_mode = "otg";
+	usb-role-switch;
 	status = "okay";
+
+	port {
+		usb2phy0_typec_hs: endpoint {
+			remote-endpoint = <&typec_hs_usb2phy0>;
+		};
+	};
 };
 
 &usb2phy0 {
@@ -704,10 +710,4 @@ &usb2phy0 {
 
 &usb2phy0_otg {
 	status = "okay";
-
-	port {
-		usb2phy0_typec_hs: endpoint {
-			remote-endpoint = <&typec_hs_usb2phy0>;
-		};
-	};
 };

-- 
2.51.0

Re: [PATCH 1/2] arm64: dts: rockchip: Simplify usb-c-connector port on rk3566-pinenote

[Krzysztof Kozlowski]

On 09/11/2025 18:05, Diederik de Haas wrote:
> The USB-C connector on the PineNote has only 1 port, so there's no need
> for a 'ports' node with address-/size-cells properties as a single
> 'port' node suffices.
> 
> This fixes the following DT validation issue:
> 
>   Warning (graph_child_address): /i2c@fe5c0000/tcpc@60/connector/ports:
>     graph node has single child node 'port@0',
>     #address-cells/#size-cells are not necessary

This is not a DT validation, but DTC warning which we do not really fix.
Are you sure the 'port' is accepted by bindings?

Best regards,
Krzysztof

Re: [PATCH 0/2] Fixes for PineNote DT validation issues

[Diederik de Haas]

On Sun Nov 9, 2025 at 6:05 PM CET, Diederik de Haas wrote:
> These patches fix the following DeviceTree validation issues on the
> PineNote dtb files:

Please ignore this patch set. Sorry about the noise.

Cheers,
  Diederik

>     Warning (graph_child_address): /i2c@fe5c0000/tcpc@60/connector/ports:
>       graph node has single child node 'port@0', #address-cells/#size-cells
>       are not necessary
>
>     usb2phy@fe8a0000 (rockchip,rk3568-usb2phy): otg-port: 'port' does not
>       match any of the regexes: '^pinctrl-[0-9]+$'
>
> And with these 2 fixes, there are no more DT validation issues :-)
>
> The fix for the 2nd issue also fix these kernel errors:
>
>   rockchip-usb2phy fe8a0000.usb2phy: Failed to create device link (0x180) with supplier port0 for /usb2phy@fe8a0000/otg-port
>   rockchip-usb2phy fe8a0000.usb2phy: Failed to create device link (0x180) with supplier 3-0060 for /usb2phy@fe8a0000/otg-port
>
> Cheers,
>   Diederik
>
> Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
> ---
> Diederik de Haas (2):
>       arm64: dts: rockchip: Simplify usb-c-connector port on rk3566-pinenote
>       arm64: dts: rockchip: Move otg-port to controller on rk3566-pinenote
>
>  arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 27 +++++++++--------------
>  1 file changed, 10 insertions(+), 17 deletions(-)
> ---
> base-commit: 6146a0f1dfae5d37442a9ddcba012add260bceb0
> change-id: 20251109-rk3566-pinenote-dt-fixes-upstream-1fb32eff43ea
>
> Best regards,

Re: [PATCH 1/2] arm64: dts: rockchip: Simplify usb-c-connector port on rk3566-pinenote

[Heiko Stübner]

Am Sonntag, 9. November 2025, 18:37:26 Mitteleuropäische Normalzeit schrieb Krzysztof Kozlowski:
> On 09/11/2025 18:05, Diederik de Haas wrote:
> > The USB-C connector on the PineNote has only 1 port, so there's no need
> > for a 'ports' node with address-/size-cells properties as a single
> > 'port' node suffices.
> > 
> > This fixes the following DT validation issue:
> > 
> >   Warning (graph_child_address): /i2c@fe5c0000/tcpc@60/connector/ports:
> >     graph node has single child node 'port@0',
> >     #address-cells/#size-cells are not necessary
> 
> This is not a DT validation, but DTC warning which we do not really fix.

That is good to know. Is the same true for other dtc warnings?

Thanks
Heiko

Re: [PATCH 1/2] arm64: dts: rockchip: Simplify usb-c-connector port on rk3566-pinenote

[Krzysztof Kozlowski]

On 09/11/2025 23:16, Heiko Stübner wrote:
> Am Sonntag, 9. November 2025, 18:37:26 Mitteleuropäische Normalzeit schrieb Krzysztof Kozlowski:
>> On 09/11/2025 18:05, Diederik de Haas wrote:
>>> The USB-C connector on the PineNote has only 1 port, so there's no need
>>> for a 'ports' node with address-/size-cells properties as a single
>>> 'port' node suffices.
>>>
>>> This fixes the following DT validation issue:
>>>
>>>   Warning (graph_child_address): /i2c@fe5c0000/tcpc@60/connector/ports:
>>>     graph node has single child node 'port@0',
>>>     #address-cells/#size-cells are not necessary
>>
>> This is not a DT validation, but DTC warning which we do not really fix.
> 
> That is good to know. Is the same true for other dtc warnings?
>

No, depends, the same for compiler warnings. That's the only warning I
remember we considered moving from W=1 to W=2.

Best regards,
Krzysztof