From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: build regression with "rcar-du: Remove platform data support"
Date: Mon, 01 Dec 2014 15:25:06 +0200 [thread overview]
Message-ID: <5028621.aLK7lB68Yl@avalon> (raw)
In-Reply-To: <12234794.nfiRtpFgV8@wuerfel>
Hi Arnd,
On Monday 01 December 2014 14:09:36 Arnd Bergmann wrote:
> Hi Laurent,
>
> linux-next has failed to build with lager_defconfig and marzen_defconfig for
> a while, with this error:
>
> arch/arm/mach-shmobile/board-lager.c:35:41: fatal error:
> linux/platform_data/rcar-du.h: No such file or directory #include
> <linux/platform_data/rcar-du.h>
>
> which is evidently the result of your patch
>
> commit 2378ad1228d2cdae0ea5448beb4fb2b42ebaf99c
> Author: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Date: Wed Sep 17 02:07:52 2014 +0300
>
> drm: rcar-du: Remove platform data support
>
> All platforms now instantiate the DU through DT, platform data support
> isn't needed anymore.
>
> Signed-off-by: Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com>
>
> that removes the header files. I assume some dependency wasn't tracked
> right, since linux-next still has these.
>
> $ git grep rcar_du_ arch/arm
> arch/arm/mach-shmobile/board-lager.c:static struct rcar_du_encoder_data
> lager_du_encoders[] = { arch/arm/mach-shmobile/board-lager.c:static const
> struct rcar_du_platform_data lager_du_pdata __initconst = {
> arch/arm/mach-shmobile/board-marzen.c:static struct rcar_du_encoder_data
> du_encoders[] = { arch/arm/mach-shmobile/board-marzen.c:static const struct
> rcar_du_platform_data du_pdata __initconst = {
>
> Can we please fix this before the merge window? Should the platform
> device registration just get removed from the two board files?
That's what I've proposed in
http://www.spinics.net/lists/dri-devel/msg72750.html
Dave, could you please reply to that ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-12-01 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 13:09 build regression with "rcar-du: Remove platform data support" Arnd Bergmann
2014-12-01 13:25 ` Laurent Pinchart [this message]
2014-12-01 15:10 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5028621.aLK7lB68Yl@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).