From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: mach-imx: Remove board entries in dt_board_compat
Date: Mon, 13 Aug 2012 16:48:11 -0500 [thread overview]
Message-ID: <5029761B.9080502@gmail.com> (raw)
In-Reply-To: <20120813151509.GB27393@S2101-09.ap.freescale.net>
On 08/13/2012 10:15 AM, Shawn Guo wrote:
> On Thu, Jul 05, 2012 at 03:46:23PM +0800, Shawn Guo wrote:
>> On Thu, Jul 05, 2012 at 09:13:18AM +0200, Sascha Hauer wrote:
>>> Shawn,
>>>
>>> Is this ok with you?
>>>
>> No.
>>
>> http://thread.gmane.org/gmane.linux.ports.arm.kernel/172558/focus=172703
>>
> I change my mind. Though it's really a pity to lose a concentrated
> place maintaining a full list of compatible strings of all supported
> board, I'm more concerned by the dt_board_compat matching efficiency
> when the table gets longer.
>
I think this is needless churn. You can't say board entries are never
needed. Perhaps we've been overly active in adding all compatible
strings before they are needed. When you add a new board, it is fine to
match against the soc string without changing the kernel, but the dtb
should still have a more specific string. Then if you need to add
something board specific later, you can add the match entry and
corresponding board specific code.
Rob
next prev parent reply other threads:[~2012-08-13 21:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-17 14:04 [PATCH 1/2] ARM: mach-imx: Remove board entries in dt_board_compat Fabio Estevam
2012-06-17 14:04 ` [PATCH 2/2] ARM: mach-mxs: " Fabio Estevam
2012-06-17 14:06 ` Marek Vasut
2012-07-05 7:13 ` [PATCH 1/2] ARM: mach-imx: " Sascha Hauer
2012-07-05 7:46 ` Shawn Guo
2012-08-13 15:15 ` Shawn Guo
2012-08-13 15:18 ` Marek Vasut
2012-08-13 21:37 ` Matt Sealey
2012-08-13 16:56 ` Fabio Estevam
2012-08-14 1:28 ` Shawn Guo
2012-08-13 21:48 ` Rob Herring [this message]
2012-08-14 1:26 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5029761B.9080502@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).