linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jason77.wang@gmail.com (Hui Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] ARM: dts: imx6q-sabrelite: add eeti egalax
Date: Thu, 16 Aug 2012 14:53:23 +0800	[thread overview]
Message-ID: <502C98E3.5080306@gmail.com> (raw)
In-Reply-To: <20120815130108.GB2258@S2101-09.ap.freescale.net>

Shawn Guo wrote:
> On Wed, Aug 15, 2012 at 06:31:48PM +0800, Hui Wang wrote:
>   
>> i.MX6Q sabrelite board uses i2c3 to connect an eeti egalax
>> touchscreen controller, add it as an i2c slave device in the dts.
>>
>> Signed-off-by: Hui Wang <jason77.wang@gmail.com>
>> ---
>>  arch/arm/boot/dts/imx6q-sabrelite.dts |   16 ++++++++++++++++
>>  arch/arm/boot/dts/imx6q.dtsi          |    7 +++++++
>>  2 files changed, 23 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts
>> index 72f30f3..4a68e1f 100644
>> --- a/arch/arm/boot/dts/imx6q-sabrelite.dts
>> +++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
>> @@ -54,6 +54,7 @@
>>  							   144  0x80000000	/* MX6Q_PAD_EIM_D22__GPIO_3_22 */
>>  							   121  0x80000000	/* MX6Q_PAD_EIM_D19__GPIO_3_19 */
>>  							   953  0x80000000	/* MX6Q_PAD_GPIO_0__CCM_CLKO */
>> +							   972  0x10		/* MX6Q_PAD_GPIO_9__GPIO_1_9 */
>>  							   >;
>>  					};
>>  				};
>> @@ -115,6 +116,21 @@
>>  					VDDIO-supply = <&reg_3p3v>;
>>  				};
>>  			};
>> +
>> +			i2c at 021a8000 { /* I2C3 */
>> +				status = "okay";
>> +				clock-frequency = <100000>;
>> +				pinctrl-names = "default";
>> +				pinctrl-0 = <&pinctrl_i2c3_1>;
>> +
>> +				egalax_ts at 04 {
>> +					compatible = "eeti,egalax_ts";
>> +					reg = <0x04>;
>> +					interrupt-parent = <&gpio1>;
>> +					interrupts = <9 2>;
>>     
>
> So you take this interrupt as falling-edge, while I see IRQF_TRIGGER_LOW
> is used in driver with request_threaded_irq call.
>
> Regards,
> Shawn
>
>   
Yes, you are right. Should be 8 instead of 2.

Regards,
Hui.

  reply	other threads:[~2012-08-16  6:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-15 10:31 [PATCH v3 0/3] Input: egalax_ts: parse devicetree to get gpio Hui Wang
2012-08-15 10:31 ` [PATCH v3 1/3] Input: egalax_ts: get gpio from devicetree node Hui Wang
2012-08-15 10:31   ` [PATCH v3 2/3] Input: add devicetree binding note for egalax_ts Hui Wang
2012-08-15 10:31     ` [PATCH v3 3/3] ARM: dts: imx6q-sabrelite: add eeti egalax Hui Wang
2012-08-15 13:01       ` Shawn Guo
2012-08-16  6:53         ` Hui Wang [this message]
2012-08-15 12:53     ` [PATCH v3 2/3] Input: add devicetree binding note for egalax_ts Shawn Guo
2012-08-16  6:48       ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502C98E3.5080306@gmail.com \
    --to=jason77.wang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).