From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17877C87FDB for ; Mon, 11 Aug 2025 14:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lk+7uH5ULw993iOk2rMCszBT5TLvgX93elDnnsS9OhQ=; b=GnOkNWMHx77rZaNDXBHJgGWini FQUEhCU/oJ/Slt8DkyG8ygqp2uzFYSUcMPqMJLCf2d5Qdsp7g8igQJiIdw2Nlh4HQNlQziHe7P4Pt pdTrRfVRStWYxxfmfpNs2SMIrJQ9JJlAnx6FPQy0FlIdu1tGOvelnt/oOI8G3pRNliXiUJwFCvgXK MJdtfPK3sQP462dxoohwllrAzb8C91W6Q7RsKL5kE46fOW765aEPpWta78+hZbiCmJa8flodBh7De kGIoGjE7qdtBw80E6B3KAunL0bhpFnIU/le4IqmiFbE2HjK4nTSFSXIVybtZQErGHN2Rp3i0HnapQ uQPai/pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulTkh-000000084dR-2in9; Mon, 11 Aug 2025 14:43:55 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulSyx-00000007tlY-3ABk; Mon, 11 Aug 2025 13:54:37 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1754920461; cv=none; d=zohomail.com; s=zohoarc; b=V0bRZFgU/x4fCifmcfkC8/92g3rLVnGoJU100JXU3FH3bd1wPaizA22pWv1TEKU8Of5p6MRZD95e/xMPOngqWd6SrKmuuZ+JPxNgQia3KgKqGOpogMbmvnbrPhjGI6jpi1qsj+OHsQDkmoDFagv8c/uqIeHg8oX6GcJTZf7doQ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1754920461; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=lk+7uH5ULw993iOk2rMCszBT5TLvgX93elDnnsS9OhQ=; b=D/lqdrCOjRYu6BArMpaHNf0VtWJUZV59bvYt8vVjSTm70+zA92TXrNcDEQDO/TUKYJIgpeJhaigANSvkFw76nePnBaAfu/THa/+gkkDsomYwGa8RQVhNCdn5peml69jbwQg9qI0hzug+6j6Lz7o3F+RqOw+tT9GdlXWEVtG9HZo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=detlev.casanova@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1754920461; s=zohomail; d=collabora.com; i=detlev.casanova@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=lk+7uH5ULw993iOk2rMCszBT5TLvgX93elDnnsS9OhQ=; b=R/QEnEmEfVw3riAD1p4eIR4YL+vp9qoQYshiLENUZMzO5CLhPqlW54H6b1gT+Gjm yLzi+g8g8ldNqrrn428Hq0acu4kuBfZLlsZJZjtod7d7RBp9NwC6jp/bwcEfjrDNE6d 8y1FHRRwTcBlvUcQWyC+qLiE6iWibOACNnq/pGDw= Received: by mx.zohomail.com with SMTPS id 1754920460001181.5866401293647; Mon, 11 Aug 2025 06:54:20 -0700 (PDT) From: Detlev Casanova To: linux-kernel@vger.kernel.org, Krzysztof Kozlowski Cc: Mauro Carvalho Chehab , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH v2 06/12] media: rkvdec: Add RCB and SRAM support Date: Mon, 11 Aug 2025 09:54:18 -0400 Message-ID: <5031584.31r3eYUQgx@trenzalore> In-Reply-To: <5c7767d1-1f28-48e0-bf8b-a224151fb007@kernel.org> References: <20250808200340.156393-1-detlev.casanova@collabora.com> <20250808200340.156393-7-detlev.casanova@collabora.com> <5c7767d1-1f28-48e0-bf8b-a224151fb007@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250811_065435_851970_511F7AF4 X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Monday, 11 August 2025 02:13:42 EDT Krzysztof Kozlowski wrote: > On 08/08/2025 22:03, Detlev Casanova wrote: > > - vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); > > - > > > > irq = platform_get_irq(pdev, 0); > > if (irq <= 0) > > > > return -ENXIO; > > > > @@ -1204,6 +1217,10 @@ static int rkvdec_probe(struct platform_device > > *pdev)> > > return ret; > > > > } > > > > + rkvdec->sram_pool = of_gen_pool_get(pdev->dev.of_node, "sram", 0); > > Didn't you just add new ABI? Oh do you mean rkvdec_rcb_buf_count() ? I could indeed use that instead here. > > + if (!rkvdec->sram_pool && rkvdec->config->rcb_num > 0) > > + dev_info(&pdev->dev, "No sram node, RCB will be stored in RAM\n"); > > + > > Best regards, > Krzysztof