From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] gpio/mxs: adopt irq_domain support for mxs gpio driver
Date: Tue, 21 Aug 2012 08:16:37 -0500 [thread overview]
Message-ID: <50338A35.9070803@gmail.com> (raw)
In-Reply-To: <CACRpkda2hc2eZaFqRfAPEG7KfLd3mFFdWze=V45=w84nRPqijA@mail.gmail.com>
On 08/21/2012 08:01 AM, Linus Walleij wrote:
> On Mon, Aug 20, 2012 at 4:19 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
>
>> Remove irq_domain_add_legacy call from mach-mxs.c and have the gpio
>> driver adopt irqdomain support, so that we can have the mapping
>> between gpio and irq number available without using virtual_irq_start
>> and MXS_GPIO_IRQ_START.
>
> Seems like a good thing to do, but with Grant and Rob being better at
> irqdomain than me I'd prefer one of them to have a look at this too.
>
>> + irq_base = irq_alloc_descs(-1, 0, 32, numa_node_id());
>> + if (irq_base < 0)
>> + return irq_base;
>> +
>> + port->domain = irq_domain_add_legacy(np, 32, irq_base, 0,
>> + &irq_domain_simple_ops, NULL);
>
> For example I want to understand if it'd be possible to use a
> linear domain here.
Unfortunately, not if you care about your irq base and need sequential
irq numbers which is the case for non-DT.
Rob
>
> Yours,
> Linus Walleij
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2012-08-21 13:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 14:19 [PATCH 0/6] Enable SPARSE_IRQ for mach-mxs Shawn Guo
2012-08-20 14:19 ` [PATCH 1/6] gpio/mxs: adopt irq_domain support for mxs gpio driver Shawn Guo
2012-08-21 13:01 ` Linus Walleij
2012-08-21 13:16 ` Rob Herring [this message]
2012-08-22 2:14 ` Shawn Guo
2012-08-23 21:49 ` Linus Walleij
2012-08-24 1:09 ` Shawn Guo
2012-08-31 22:28 ` Linus Walleij
2012-09-03 0:28 ` Shawn Guo
2012-08-20 14:19 ` [PATCH 2/6] ARM: mxs: retrieve timer irq from device tree Shawn Guo
2012-08-20 14:19 ` [PATCH 3/6] ARM: mxs: select MULTI_IRQ_HANDLER Shawn Guo
2012-08-20 14:19 ` [PATCH 4/6] ARM: mxs: adopt irq_domain support for icoll driver Shawn Guo
2012-08-20 14:19 ` [PATCH 5/6] ARM: mxs: select SPARSE_IRQ Shawn Guo
2012-08-20 14:24 ` Shawn Guo
2012-08-20 14:20 ` [PATCH 6/6] ARM: mxs: remove mach/irqs.h Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50338A35.9070803@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).