From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F16CD30006 for ; Fri, 18 Oct 2024 13:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xrzeEoBsCionoKUR266fpAo3BaG9LZtKR8xkrwhis4I=; b=iU/dQbOvJVLU3tEFgpE4WtoX9V xdl3MTDSPEIEZf3cy4b05eQhd+gbFk/Hy5IqkW4Zb1NdQMz117X3UZwk0Py1uElQBb+5Ovci9P/3K 3ymijI83q2dePLh15ydnTB9XNSJp+xLM/WcTgbYgO1whDu5TwaJIN8+UHlalyIh3L1DNiRWv8EDFm PnoFfDOqcYwCavaV0JtVBKCHUfZQKGL/ue9VBenyz8Ruw/YaQ6Jh2BWNyrpkSSYM7gkBOnsHFJvuc /xnBH0GuYDnT3tbeey+61S14h/AxSmYhbHR7zJv32aKZN/JfeIX36AUMSBck8qphoVC8uC09sI5lo ncl8e+aA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1moN-00000000qWa-43RN; Fri, 18 Oct 2024 13:14:35 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1mms-00000000qDc-2ewl for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 13:13:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1729257182; x=1760793182; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xrzeEoBsCionoKUR266fpAo3BaG9LZtKR8xkrwhis4I=; b=MzYx/6euhHoEI4v8joOrNcMmU9nQ5DG7AHRHN91blfMgvc6hbItSjOAV 692rmohpdp+CuTdi6U1bpLg5BkQt9/jiWEeLxKbzmJff0vl6sLD7luKTq LUvNmdpadAGrWfFuHIKHXUeub/3+2qJ+shZrsgiypPqNUyo2Zl+rreP5D yrpyexpAHMN/hVEUxbJ/ou/9HkHwCVdj2x5AEkQD18HpDYDkNfJpnb1kJ v+FXiGPWN2iX1ncYAFc4v885Ov2GEEWYQkWeyEvDb2GQN53mbjOYQBLTF q9XuB6/ab92SKOVmiOqPlX1kUXfIZpq+5dWR++hIwfd43TTPblIlhTsF6 g==; X-CSE-ConnectionGUID: 3KoUDJEnQRaRloi9VBQ63A== X-CSE-MsgGUID: NPQH+y/pSTScykETWFj9YQ== X-IronPort-AV: E=Sophos;i="6.11,213,1725314400"; d="scan'208";a="39543900" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 18 Oct 2024 15:12:58 +0200 X-CheckPoint: {67125EDA-9-BD84CFBF-E7C15A70} X-MAIL-CPID: 1966C4EF9B0FB9E0C3310EAEA66099E9_3 X-Control-Analysis: str=0001.0A682F19.67125EDA.0060,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id AB87F16ACBC; Fri, 18 Oct 2024 15:12:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1729257173; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=xrzeEoBsCionoKUR266fpAo3BaG9LZtKR8xkrwhis4I=; b=l4abCq4GzoqmZ9BJX3njeI/FwjZI05uwLBz+mQMuGVbCBcbm1vRsJbUvYSO5vvavbmWhEv y38ZqQMrSpXDdl5nfXYT/JHFBzztTs0+BGKJtB9TRP8jNwct3OJ9BGPLlxMHQ1nzO+uSHY jW9NvLXRt1L/k40SMmI0ImpPm8H38zP7b5Z7XVkCk3kS16WZnpnoRaHh4qSSAYXxmc0YCj H7nii7oha2YVtDLjD33iRrAzwTQHHLIjVaVBh6G8uWt63MyibvhKD5GUYIZfI3gEY9CsBw /LumWuZE7UPbJBgSvdhgHmK6/uEGDhg9kGk6WHA9AhAxqiQ2JZRqA/LO6JWM2g== From: Alexander Stein To: Liu Ying , dri-devel@lists.freedesktop.org Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, marex@denx.de, stefan@agner.ch, Dmitry Baryshkov Subject: Re: [PATCH 4/5] drm/bridge: imx8mp-hdmi-tx: Set output_port to 1 Date: Fri, 18 Oct 2024 15:12:49 +0200 Message-ID: <5035853.0VBMTVartN@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20241018064813.2750016-1-victor.liu@nxp.com> <20241018064813.2750016-5-victor.liu@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_061303_190920_76D4BBB6 X-CRM114-Status: GOOD ( 26.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 18. Oktober 2024, 14:31:20 CEST schrieb Dmitry Baryshkov: > On Fri, Oct 18, 2024 at 02:48:12PM +0800, Liu Ying wrote: > > Set DW HDMI platform data's output_port to 1 in imx8mp_dw_hdmi_probe() > > so that dw_hdmi_probe() called by imx8mp_dw_hdmi_probe() can tell the > > DW HDMI bridge core driver about the output port we are using, hence > > the next bridge can be found in dw_hdmi_parse_dt() according to the port > > index, and furthermore the next bridge can be attached to bridge chain = in > > dw_hdmi_bridge_attach() when the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is > > set. The output_port value aligns to the value used by devicetree. > > This is a preparation for making the i.MX8MP LCDIF driver use > > drm_bridge_connector which requires the DRM_BRIDGE_ATTACH_NO_CONNECTOR > > flag. > >=20 > > Signed-off-by: Liu Ying > > --- > > drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c b/drivers/gpu/= drm/bridge/imx/imx8mp-hdmi-tx.c > > index 8fcc6d18f4ab..54a53f96929a 100644 > > --- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c > > +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c > > @@ -96,6 +96,7 @@ static int imx8mp_dw_hdmi_probe(struct platform_devic= e *pdev) > > return dev_err_probe(dev, PTR_ERR(hdmi->pixclk), > > "Unable to get pixel clock\n"); > > =20 > > + plat_data->output_port =3D 1; >=20 > This will break compatibility with older DT files, which don't have > output port. I think you need to add output_port_optional flag to > dw_hdmi_plat_data and still return 0 from dw_hdmi_parse_dt() if the flag > is set, but there is no remote node. >=20 > Last, but not least, this changes behaviour of the connector. > dw_hdmi_connector_create() implements CEC support, handles > ycbcr_420_allowed, HDR metadata, etc. Mh, I was suspecting the same, but I couldn't see any regression regarding = CEC. Maybe the change is not doing what it is supposed to do... I'll check again on Monday. Best regards, Alexander > We are slowly moving towards the supporting all of this in bridge > connector via the HDMI Connector framework, but this is not > implemented for now. >=20 > > plat_data->mode_valid =3D imx8mp_hdmi_mode_valid; > > plat_data->phy_ops =3D &imx8mp_hdmi_phy_ops; > > plat_data->phy_name =3D "SAMSUNG HDMI TX PHY"; >=20 >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/