From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Enable gcov support on the ARM architecture
Date: Wed, 10 Sep 2014 16:49:28 +0200 [thread overview]
Message-ID: <5037670.HaHQaHAl5C@wuerfel> (raw)
In-Reply-To: <CAAqcGHmKzgGbc93w_Vm=WSp-5eYvdMSVBCoa43=C1wuQwSaKaA@mail.gmail.com>
On Wednesday 10 September 2014 16:45:07 Riku Voipio wrote:
> On 8 September 2014 16:25, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday 08 September 2014 15:59:34 Riku Voipio wrote:
> >> diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile
> >> index 38ddd9f..979c4e9 100644
> >> --- a/arch/arm/kernel/Makefile
> >> +++ b/arch/arm/kernel/Makefile
> >> @@ -5,6 +5,8 @@
> >> CPPFLAGS_vmlinux.lds := -DTEXT_OFFSET=$(TEXT_OFFSET)
> >> AFLAGS_head.o := -DTEXT_OFFSET=$(TEXT_OFFSET)
> >>
> >> +GCOV_PROFILE := n
> >> +
> >> ifdef CONFIG_FUNCTION_TRACER
> >> CFLAGS_REMOVE_ftrace.o = -pg
> >> CFLAGS_REMOVE_insn.o = -pg
>
> > This part doesn't look right: you don't want to disable profiling for
> > the entire directory, only for the parts on which it cannot be used.
>
> You are right. I can just remove that hunk and I can both boot and
> record coverage info from arch/arm/kernel. Any other comments, or
> should I just resubmit without arch/arm/kernel bits?
Without that part it looks ok to me.
Arnd
next prev parent reply other threads:[~2014-09-10 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 12:59 [PATCH] Enable gcov support on the ARM architecture Riku Voipio
2014-09-08 13:25 ` Arnd Bergmann
2014-09-10 13:45 ` Riku Voipio
2014-09-10 14:49 ` Arnd Bergmann [this message]
2014-09-11 8:15 ` [PATCH v2] " Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5037670.HaHQaHAl5C@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox