From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: omap_hwmod: Fix up resource names when booted with devicetree
Date: Fri, 24 Aug 2012 19:20:30 +0300 [thread overview]
Message-ID: <5037A9CE.1080809@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1208241536290.25436@utopia.booyaka.com>
Hi Paul,
On 08/24/2012 06:38 PM, Paul Walmsley wrote:
> Do we need both this one and your '[PATCH] driver core: Check if r->name
> is valid in platform_get_resource_byname()' ? Or would that second patch
> be enough? Is the crash happening in the platform_get_resource_byname()
> iterator?
The crash happens in platform_get_resource_byname(). What I see as a problem
that when we boot without DT the r->name is configured for the hwmods. If we
boot with DT we discard the resources created by the OF (which also have the
r->name configured). We replace the resources from hwmods but we do not fix up
the resource names (which is done in other cases).
I have sent the patch for the drivers core as well since I think it is a good
practice anyway to check for NULL pointer before strcmp().
Either is good, but IMHO we should fix this in omap_hwmod (at least).
--
P?ter
next prev parent reply other threads:[~2012-08-24 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 13:54 [PATCH] ARM: omap_hwmod: Fix up resource names when booted with devicetree Peter Ujfalusi
2012-08-24 15:38 ` Paul Walmsley
2012-08-24 16:20 ` Peter Ujfalusi [this message]
2012-09-05 14:27 ` Benoit Cousson
2012-09-05 14:46 ` Benoit Cousson
2012-09-05 14:46 ` Benoit Cousson
2012-09-05 20:05 ` Vaibhav Hiremath
2012-09-06 7:37 ` Benoit Cousson
2012-09-06 8:28 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5037A9CE.1080809@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).