linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ludovic.desroches@atmel.com (ludovic.desroches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver
Date: Tue, 28 Aug 2012 17:10:00 +0200	[thread overview]
Message-ID: <503CDF48.5080201@atmel.com> (raw)
In-Reply-To: <4f3dcfbf1e8eab3e251ab3558e9e1e9123643928.1345618760.git.n.voss@weinmann.de>

Hi Nikolaus,

I forgot one correction I did in your patch:

Le 11/08/2011 11:49 AM, Nikolaus Voss a ?crit :
[...]

> diff --git a/arch/arm/mach-at91/at91sam9261_devices.c b/arch/arm/mach-at91/at91sam9261_devices.c
> index 9295e90..27fddc1 100644
> --- a/arch/arm/mach-at91/at91sam9261_devices.c
> +++ b/arch/arm/mach-at91/at91sam9261_devices.c
> @@ -283,9 +283,18 @@ static struct i2c_gpio_platform_data pdata = {
>   	.udelay			= 2,		/* ~100 kHz */
>   };
>
> +static const struct platform_device_id twi_ip_type = {
> +	/*
> +	 * driver_data is 2 for SAM9261 compatible ip, see enum twi_ip_id in
> +	 * drivers/i2c/busses/i2c-at91.c
> +	 */
> +	.driver_data	= 2,
> +};
> +
>   static struct platform_device at91sam9261_twi_device = {
>   	.name			= "i2c-gpio",
>   	.id			= -1,
> +	.id_entry		= &twi_ip_type,
>   	.dev.platform_data	= &pdata,
>   };
>

[...]

You add the id_entry to the i2c-gpio device instead of at91_i2c device.

Regards

Ludovic

  parent reply	other threads:[~2012-08-28 15:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1345618760.git.n.voss@weinmann.de>
     [not found] ` <4f3dcfbf1e8eab3e251ab3558e9e1e9123643928.1345618760.git.n.voss@weinmann.de>
2012-08-27 10:16   ` [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver ludovic.desroches
2012-08-27 10:40     ` Yanes Martinez Adrian
2012-08-27 12:04       ` ludovic.desroches
2012-08-27 12:45         ` Yanes Martinez Adrian
2012-08-27 13:32           ` Voss, Nikolaus
2012-08-27 14:00             ` ludovic.desroches
2012-08-27 14:29               ` Voss, Nikolaus
2012-09-11  8:26                 ` Nicolas Ferre
2012-09-11 22:13                   ` Wolfram Sang
2012-08-30  7:35             ` ludovic.desroches
2012-08-28 15:10   ` ludovic.desroches [this message]
2012-08-28 15:32     ` Voss, Nikolaus
     [not found] ` <6acdbd0f06cb9902efc510346564e10b07fa0b91.1345618760.git.n.voss@weinmann.de>
2012-08-27 10:24   ` [PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios ludovic.desroches
2012-08-27 13:22     ` Voss, Nikolaus
2012-08-27 13:27       ` ludovic.desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503CDF48.5080201@atmel.com \
    --to=ludovic.desroches@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).