From: florian.vaussard@epfl.ch (Florian Vaussard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] i2c-omap: Fix incorrect adapter id when booting from a device tree
Date: Fri, 31 Aug 2012 11:53:37 +0200 [thread overview]
Message-ID: <504089A1.3030000@epfl.ch> (raw)
In-Reply-To: <5040806C.9080003@ti.com>
Hi Benoit,
> [ 0.658843] omap_i2c i2c.15: bus -1 rev2.4.0 at 400 kHz
> [ 0.760192] omap_i2c i2c.16: bus -1 rev2.4.0 at 400 kHz
> [ 0.775817] omap_i2c i2c.17: bus -1 rev2.4.0 at 400 kHz
> [ 0.791442] omap_i2c i2c.18: bus -1 rev2.4.0 at 400 kHz
>
> OK, it is true that the current log is not that nice with bus -1, but
> maybe we should just remove that.
>
> Or we can potentially retrieve the i2c adapter number assign later, and
> delay the log.
>
>> r = i2c_add_numbered_adapter(adap);
>> if (r) {
>> dev_err(dev->dev, "failure adding adapter\n");
I agree, we should defer the log if we want a nice print. I will send a
new patch.
Regards,
Florian
next prev parent reply other threads:[~2012-08-31 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 7:52 [PATCH 0/2] dts for i2c-omap: fix incorrect adapter id Florian Vaussard
2012-08-31 7:52 ` [PATCH 1/2] i2c-omap: Fix incorrect adapter id when booting from a device tree Florian Vaussard
2012-08-31 9:14 ` Benoit Cousson
2012-08-31 9:53 ` Florian Vaussard [this message]
2012-08-31 7:52 ` [PATCH 2/2] arm/dts: Add i2c aliases for OMAP3 and OMAP4/AM33xx Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504089A1.3030000@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).