From: "Heiko Stübner" <heiko@sntech.de>
To: Shawn Lin <shawn.lin@rock-chips.com>, Felix Gu <ustc.gu@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Felix Gu <ustc.gu@gmail.com>
Subject: Re: [PATCH] soc: rockchip: grf: Fix device node reference leak in rockchip_grf_init()
Date: Sat, 21 Feb 2026 16:28:08 +0100 [thread overview]
Message-ID: <50476327.XUcTiDjVJD@diego> (raw)
In-Reply-To: <20260217-grf-v1-1-2088c966875d@gmail.com>
Hi Felix,
Am Montag, 16. Februar 2026, 21:11:32 Mitteleuropäische Normalzeit schrieb Felix Gu:
> In rockchip_grf_init(), when syscon_node_to_regmap fails, it returns
> without calling of_node_put(), which causes a reference leak.
>
> Add the missing of_node_put() call to fix it.
>
> Fixes: 75fb63ae0312 ("soc: rockchip: grf: Support multiple grf to be handled")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Shawn was a bit earlier with a similar fix [0], so their patch will go in.
Heiko
[0] https://lore.kernel.org/all/1770814957-17762-1-git-send-email-shawn.lin@rock-chips.com/
prev parent reply other threads:[~2026-02-21 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 20:11 [PATCH] soc: rockchip: grf: Fix device node reference leak in rockchip_grf_init() Felix Gu
2026-02-21 15:28 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50476327.XUcTiDjVJD@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox