From: simon@fire.lp0.eu (Simon Arlott)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: add support for BCM2708/BCM2835 and Raspberry Pi
Date: Sat, 08 Sep 2012 13:37:01 +0100 [thread overview]
Message-ID: <504B3BED.9080204@simon.arlott.org.uk> (raw)
In-Reply-To: <1347083284-17799-1-git-send-email-swarren@wwwdotorg.org>
On 08/09/12 06:48, Stephen Warren wrote:
> +void __init bcm2708_init_irq(void)
> +{
> +}
...
> +static void __init bcm2708_timer_init(void)
> +{
> +}
There's no timer and no interrupt handler so it won't even finish
booting. It's going to stall when it tries to calculate loops per jiffy.
I don't know what you're trying to achieve. This does not add support
for the BCM2708.
See https://github.com/lp0/linux/commits/rpi-split from June 21 onwards
for separate patch commits that apply to specific devices.
On 08/09/12 06:48, Stephen Warren wrote:
> v2:
> * Rename *_BASE to *_PHYS to match Simon's rpi-split branch.
You've definitely used the rpi-linear branch if you're missing things.
The HEAD of the two branches is identical but rpi-split has a rebased
history.
--
Simon Arlott
next prev parent reply other threads:[~2012-09-08 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 5:48 [PATCH V2] ARM: add support for BCM2708/BCM2835 and Raspberry Pi Stephen Warren
2012-09-08 12:37 ` Simon Arlott [this message]
2012-09-08 16:25 ` Seth Jennings
2012-09-08 17:41 ` Stephen Warren
2012-09-08 19:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504B3BED.9080204@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox