From: prabhakar.lad@ti.com (Prabhakar Lad)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: da850/omap-l138: Add EVM specific code for VPIF to work
Date: Mon, 10 Sep 2012 17:36:13 +0530 [thread overview]
Message-ID: <504DD7B5.40908@ti.com> (raw)
In-Reply-To: <504DB28D.3070005@ti.com>
Hi Sekhar,
On Monday 10 September 2012 02:57 PM, Sekhar Nori wrote:
> Hi Prabhakar,
>
> On 9/7/2012 11:04 PM, Prabhakar Lad wrote:
>> On Fri, Sep 7, 2012 at 10:48 PM, Sekhar Nori <nsekhar@ti.com> wrote:
>
>>>> +static struct vpif_subdev_info da850_vpif_capture_sdev_info[] = {
>>>> +#if defined(CONFIG_DA850_UI_SD_VIDEO_PORT)
>>>
>>> You agreed to get rid of these multiple ifdefs but you have not fixed that.
>>>
>> I have merged the top one, at later stage when we go ahead and add sensor
>> support then we would have require to have define two
>> da850_vpif_capture_sdev_info
>> so to avoid it I have kept this one.
>
> Lets get to that when we actually add sensor support. It might make
> sense then. Right now, there is no reason to have them.
>
Ok I'll fix it for v3.
Regards,
--Prabhakar
> Thanks,
> Sekhar
>
prev parent reply other threads:[~2012-09-10 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 14:08 [PATCH v2 0/2] ARM: davinci: da850/omap-l138: add support for VPIF driver Prabhakar Lad
2012-08-20 14:08 ` [PATCH v2 1/2] ARM: da850/omap-l138: Add SoC related definitions for VPIF Prabhakar Lad
2012-09-07 17:01 ` Sekhar Nori
2012-08-20 14:08 ` [PATCH v2 2/2] ARM: da850/omap-l138: Add EVM specific code for VPIF to work Prabhakar Lad
2012-09-07 17:18 ` Sekhar Nori
2012-09-07 17:34 ` Prabhakar Lad
2012-09-10 9:27 ` Sekhar Nori
2012-09-10 12:06 ` Prabhakar Lad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DD7B5.40908@ti.com \
--to=prabhakar.lad@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).