[PATCH 0/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

[PATCH 0/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

[Florian Vaussard]

Hello,

This patch adds the support for the blue LED connected to the LEDB
pin of the TWL4030 on the Gumstix Overo when booting from the device
tree.

Build on top of Benoit's for_3.7/dts tree.

Regards,
Florian


Florian Vaussard (1):
  ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

 arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

-- 
1.7.5.4

[PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

[Florian Vaussard]

Support the blue LED connected to the LEDB pin of the TWL4030
on the Gumstix Overo.

Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
---
 arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi
index d6cc5e2..89808ce 100644
--- a/arch/arm/boot/dts/omap3-overo.dtsi
+++ b/arch/arm/boot/dts/omap3-overo.dtsi
@@ -13,6 +13,17 @@
 
 /include/ "omap3.dtsi"
 
+/ {
+	leds {
+		compatible = "gpio-leds";
+		overo {
+			label = "overo:blue:COM";
+			gpios = <&twl_gpio 19 0>;
+			linux,default-trigger = "mmc0";
+		};
+	};
+};
+
 &i2c1 {
 	clock-frequency = <2600000>;
 
@@ -40,3 +51,7 @@
 &mmc2 {
 	bus-width = <4>;
 };
+
+&twl_gpio {
+	ti,use-leds;
+};
-- 
1.7.5.4

[PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

[Benoit Cousson]

On 09/10/2012 03:16 PM, Florian Vaussard wrote:
> Support the blue LED connected to the LEDB pin of the TWL4030
> on the Gumstix Overo.
> 
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
> ---
>  arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi
> index d6cc5e2..89808ce 100644
> --- a/arch/arm/boot/dts/omap3-overo.dtsi
> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
> @@ -13,6 +13,17 @@
>  
>  /include/ "omap3.dtsi"
>  
> +/ {

BTW, I'm just wondering. Cannot we use overo without tobi?

In that case, the model and compatible should probably be used as well:

	model = "TI OMAP3 Gumstix Overo";
	compatible = "ti,omap3-overo", "ti,omap3";


> +	leds {
> +		compatible = "gpio-leds";
> +		overo {
> +			label = "overo:blue:COM";
> +			gpios = <&twl_gpio 19 0>;
> +			linux,default-trigger = "mmc0";
> +		};
> +	};
> +};
> +
>  &i2c1 {
>  	clock-frequency = <2600000>;
>  
> @@ -40,3 +51,7 @@
>  &mmc2 {
>  	bus-width = <4>;
>  };
> +
> +&twl_gpio {
> +	ti,use-leds;
> +};
> 

Otherwise, it is fine.

Thanks,
Benoit

[PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

[Florian Vaussard]

>> Support the blue LED connected to the LEDB pin of the TWL4030
>> on the Gumstix Overo.
>>
>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>> ---
>>   arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
>>   1 files changed, 15 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi
>> index d6cc5e2..89808ce 100644
>> --- a/arch/arm/boot/dts/omap3-overo.dtsi
>> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
>> @@ -13,6 +13,17 @@
>>
>>   /include/ "omap3.dtsi"
>>
>> +/ {
>
> BTW, I'm just wondering. Cannot we use overo without tobi?
>
> In that case, the model and compatible should probably be used as well:
>
> 	model = "TI OMAP3 Gumstix Overo";
> 	compatible = "ti,omap3-overo", "ti,omap3";

No, it cannot. The Overo needs to be plugged into an expansion board, at
least to get the power. Hence the absence of model and compatible in
omap3-overo.dtsi.

Regards,
Florian

[PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

[Benoit Cousson]

On 09/10/2012 03:33 PM, Florian Vaussard wrote:
>>> Support the blue LED connected to the LEDB pin of the TWL4030
>>> on the Gumstix Overo.
>>>
>>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>>> ---
>>>   arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
>>>   1 files changed, 15 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi
>>> b/arch/arm/boot/dts/omap3-overo.dtsi
>>> index d6cc5e2..89808ce 100644
>>> --- a/arch/arm/boot/dts/omap3-overo.dtsi
>>> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
>>> @@ -13,6 +13,17 @@
>>>
>>>   /include/ "omap3.dtsi"
>>>
>>> +/ {
>>
>> BTW, I'm just wondering. Cannot we use overo without tobi?
>>
>> In that case, the model and compatible should probably be used as well:
>>
>>     model = "TI OMAP3 Gumstix Overo";
>>     compatible = "ti,omap3-overo", "ti,omap3";
> 
> No, it cannot. The Overo needs to be plugged into an expansion board, at
> least to get the power. Hence the absence of model and compatible in
> omap3-overo.dtsi.

OK, cool. I was wondering because we already have a board-overo.c in the
kernel, and there is no mention of tobi.

OK, I'm adding that patch on top of the other then.

Regards,
Benoit

[PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

[Benoit Cousson]

On 09/10/2012 03:40 PM, Benoit Cousson wrote:
> On 09/10/2012 03:33 PM, Florian Vaussard wrote:
>>>> Support the blue LED connected to the LEDB pin of the TWL4030
>>>> on the Gumstix Overo.
>>>>
>>>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>>>> ---
>>>>   arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
>>>>   1 files changed, 15 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi
>>>> b/arch/arm/boot/dts/omap3-overo.dtsi
>>>> index d6cc5e2..89808ce 100644
>>>> --- a/arch/arm/boot/dts/omap3-overo.dtsi
>>>> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
>>>> @@ -13,6 +13,17 @@
>>>>
>>>>   /include/ "omap3.dtsi"
>>>>
>>>> +/ {
>>>
>>> BTW, I'm just wondering. Cannot we use overo without tobi?
>>>
>>> In that case, the model and compatible should probably be used as well:
>>>
>>>     model = "TI OMAP3 Gumstix Overo";
>>>     compatible = "ti,omap3-overo", "ti,omap3";
>>
>> No, it cannot. The Overo needs to be plugged into an expansion board, at
>> least to get the power. Hence the absence of model and compatible in
>> omap3-overo.dtsi.
> 
> OK, cool. I was wondering because we already have a board-overo.c in the
> kernel, and there is no mention of tobi.
> 
> OK, I'm adding that patch on top of the other then.

I'm just going to update the subject to:
ARM: dts: omap3-overo: Add support for the blue LED

regards,
Benoit

[PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

[Florian Vaussard]

>>>
>>> BTW, I'm just wondering. Cannot we use overo without tobi?
>>>
>>> In that case, the model and compatible should probably be used as well:
>>>
>>>      model = "TI OMAP3 Gumstix Overo";
>>>      compatible = "ti,omap3-overo", "ti,omap3";
>>
>> No, it cannot. The Overo needs to be plugged into an expansion board, at
>> least to get the power. Hence the absence of model and compatible in
>> omap3-overo.dtsi.
>
> OK, cool. I was wondering because we already have a board-overo.c in the
> kernel, and there is no mention of tobi.

In board-overo.c, the various features of each expansion board are
configured using CONFIG_* options, which is not possible when booting
with a device tree.

Regards,
Florian