Re: [PATCH v1 3/7] dt-bindings: clock: rk3368: Add SCLK_MIPIDSI_24M

[Heiko Stuebner <heiko@sntech.de>]

Hi,

Am Montag, 1. September 2025, 02:17:00 Mitteleuropäische Sommerzeit schrieb 李维豪:
> I actually used script to get the maintainer list, but I was not sure
> whether I should send-to or cc every maintainer, so I consulted the
> AI, and the AI said to try not to do so because it might be considered
> noise email, and only send it to the main maintainers.

please don't top-post :-)
https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions


> Should I cc all the devicetree maintainers with the next patches?

Looks like we did get an Ack still with even only one maintainer listed,
so don't need a resend ... but yeah, please include people listed as
direct maintainers in the future.

Workflows differ, so when submitting a patch you can't know if maintainers
work from patchwork or directly from their inbox.

So it's safer to include more people than not enough :-)

Some trimming of the list can be done though, for example your drm patches
would list the core drm maintainers who most likely do not really care
about individual driver patches ;-) .

get_maintainers.pl thankfully does list the role, so you can decide based
on that.


Heiko


> Best regards,
> WeiHao
> 
> Heiko Stübner <heiko@sntech.de> 于2025年8月31日周日 23:00写道：
> >
> > Hi,
> > Am Sonntag, 31. August 2025, 12:48:51 Mitteleuropäische Sommerzeit schrieb WeiHao Li:
> > > Add a clock id for mipi dsi reference clock, mipi dsi node used it.
> > >
> > > Signed-off-by: WeiHao Li <cn.liweihao@gmail.com>
> >
> > you missed a number of devicetree maintainers, Rob thankfully does
> > not need to do this on his own anymore.
> >
> > so please get the appropriate list of maintainers via scripts/get_maintainer.pl
> >
> > Change itself looks fine though.
> >
> > Heiko
> >
> > > ---
> > >  include/dt-bindings/clock/rk3368-cru.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/include/dt-bindings/clock/rk3368-cru.h b/include/dt-bindings/clock/rk3368-cru.h
> > > index ebae3cbf8..b951e2906 100644
> > > --- a/include/dt-bindings/clock/rk3368-cru.h
> > > +++ b/include/dt-bindings/clock/rk3368-cru.h
> > > @@ -72,6 +72,7 @@
> > >  #define SCLK_SFC             126
> > >  #define SCLK_MAC             127
> > >  #define SCLK_MACREF_OUT              128
> > > +#define SCLK_MIPIDSI_24M     129
> > >  #define SCLK_TIMER10         133
> > >  #define SCLK_TIMER11         134
> > >  #define SCLK_TIMER12         135
> > >
> >
> >
> >
> >
>