From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/7] DMA: sun6i: Add driver for the Allwinner A31 DMA controller
Date: Mon, 10 Mar 2014 18:57 +0100 [thread overview]
Message-ID: <5055473.2ZTHMWo41J@wuerfel> (raw)
In-Reply-To: <20140310165156.GI2815@lukather>
On Monday 10 March 2014 17:51:56 Maxime Ripard wrote:
> >
> > Neither "pll6" nor "ahb1_mux" are listed in the DT binding. Also, why
> > is it the driver's business to set the parent?
>
> Those are global clocks, so it's not really part pof the driver
> binding itself. But I can add them.
No better don't then. Can you change the clk_get() call to pass
NULL as the device pointer to clarify this in the source though?
> About the reparenting itself, other devices are actually fine having
> any parent they want, only the DMA is picky about it (at least, from
> what we know), so it made sense to me to put it into the driver
> itself. Where would you put it?
Maybe Mike Turquette has an idea. We have in the past discussed
about cases where you want the default clock setting to be part
of the clock provider in some property. Could that work here?
Arnd
next prev parent reply other threads:[~2014-03-10 17:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 14:41 [PATCH v4 0/7] Add support for the Allwinner A31 DMA Controller Maxime Ripard
2014-03-10 14:41 ` [PATCH v4 1/7] clk: sunxi: Remove calls to clk_put Maxime Ripard
2014-03-10 14:41 ` [PATCH v4 2/7] ARM: sunxi: Split out the various machines into separate files Maxime Ripard
2014-03-10 14:41 ` [PATCH v4 3/7] ARM: sunxi: Move the clock protection to machine hooks Maxime Ripard
2014-03-10 14:41 ` [PATCH v4 4/7] ARM: sun6i: Protect CPU clock Maxime Ripard
2014-03-10 14:41 ` [PATCH v4 5/7] ARM: sun6i: Protect SDRAM gating bit Maxime Ripard
2014-03-10 14:41 ` [PATCH v4 6/7] DMA: sun6i: Add driver for the Allwinner A31 DMA controller Maxime Ripard
2014-03-10 15:34 ` Arnd Bergmann
2014-03-10 16:51 ` Maxime Ripard
2014-03-10 17:57 ` Arnd Bergmann [this message]
2014-03-11 8:50 ` Maxime Ripard
2014-03-11 9:52 ` Shevchenko, Andriy
2014-03-11 10:08 ` Maxime Ripard
2014-03-11 10:22 ` Shevchenko, Andriy
2014-03-10 14:41 ` [PATCH v4 7/7] ARM: sun6i: dt: Add A31 DMA controller to DTSI Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5055473.2ZTHMWo41J@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox