From: Heiko Stuebner <heiko@sntech.de>
To: Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Yangtao Li <frank.li@vivo.com>
Cc: "Yangtao Li" <frank.li@vivo.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 41/62] mmc: dw_mmc: rockchip: Convert to platform remove callback returning void
Date: Fri, 28 Jul 2023 20:24:42 +0200 [thread overview]
Message-ID: <5065221.NG923GbCHz@phil> (raw)
In-Reply-To: <20230727070051.17778-41-frank.li@vivo.com>
Am Donnerstag, 27. Juli 2023, 09:00:30 CEST schrieb Yangtao Li:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-28 18:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 6:59 [PATCH v3 01/62] mmc: sunxi: Convert to platform remove callback returning void Yangtao Li
2023-07-27 6:59 ` [PATCH v3 02/62] mmc: bcm2835: " Yangtao Li
2023-07-27 6:59 ` [PATCH v3 05/62] mmc: mtk-sd: " Yangtao Li
2023-07-27 6:59 ` [PATCH v3 10/62] mmc: sdhci: milbeaut: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 12/62] mmc: sdhci-of-at91: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 14/62] mmc: dw_mmc: exynos: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 19/62] mmc: meson-gx: " Yangtao Li
2023-07-29 19:01 ` Martin Blumenstingl
2023-07-27 7:00 ` [PATCH v3 22/62] mmc: meson-mx-sdhc: " Yangtao Li
2023-07-29 19:01 ` Martin Blumenstingl
2023-07-27 7:00 ` [PATCH v3 24/62] mmc: mxs-mmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 25/62] mmc: sdhci-of-arasan: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 32/62] mmc: sdhci-of-aspeed: remove unneeded variables Yangtao Li
2023-07-27 7:00 ` [PATCH v3 33/62] mmc: sdhci-of-aspeed: Convert to platform remove Yangtao Li
2023-07-27 7:00 ` [PATCH v3 34/62] mmc: meson-mx-sdio: Convert to platform remove callback returning void Yangtao Li
2023-07-29 19:02 ` Martin Blumenstingl
2023-07-27 7:00 ` [PATCH v3 38/62] mmc: sdhci-esdhc-imx: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 41/62] mmc: dw_mmc: rockchip: " Yangtao Li
2023-07-28 18:24 ` Heiko Stuebner [this message]
2023-07-27 7:00 ` [PATCH v3 42/62] mmc: owl: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 45/62] mmc: atmel-mci: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 46/62] mmc: sdhci-st: " Yangtao Li
2023-08-28 9:10 ` Patrice CHOTARD
2023-07-27 7:00 ` [PATCH v3 47/62] mmc: wmt-sdmmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 57/62] mmc: " Yangtao Li
2023-07-27 7:00 ` [PATCH v3 58/62] mmc: uniphier-sd: " Yangtao Li
2023-08-07 15:26 ` [PATCH v3 01/62] mmc: sunxi: " Ulf Hansson
2023-08-15 11:40 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5065221.NG923GbCHz@phil \
--to=heiko@sntech.de \
--cc=frank.li@vivo.com \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).