linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412
Date: Fri, 28 Sep 2012 16:29:49 +0530	[thread overview]
Message-ID: <50658325.8050704@linaro.org> (raw)
In-Reply-To: <003401cd9d5f$179495c0$46bdc140$@samsung.com>

On 09/28/2012 03:23 PM, Sangsu Park wrote:
> 
> On Thu, Sep 27, 2012 at 07:30 PM, Padmavathi Venna wrote:
> 
>> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
>> index fe3995c..430783b 100644
>> --- a/sound/soc/samsung/Kconfig
>> +++ b/sound/soc/samsung/Kconfig
>> @@ -1,6 +1,6 @@
>>  config SND_SOC_SAMSUNG
>>  	tristate "ASoC support for Samsung"
>> -	depends on ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5PC100 || ARCH_S5PV210
>> || ARCH_S5P64X0 || ARCH_EXYNOS4
>> +	depends on PLAT_SAMSUNG
>>  	select S3C64XX_DMA if ARCH_S3C64XX
>>  	select S3C2410_DMA if ARCH_S3C24XX
>>  	help
> 
> This code is already updated.
> 
>> @@ -63,7 +63,7 @@ config SND_SOC_SAMSUNG_SMDK_WM8580
>>
>>  config SND_SOC_SAMSUNG_SMDK_WM8994
>>  	tristate "SoC I2S Audio support for WM8994 on SMDK"
>> -	depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 ||
>> MACH_SMDK4212)
>> +	depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 ||
>> MACH_SMDK4212 || MACH_SMDK4412 || MACH_EXYNOS5_DT)
>>  	depends on I2C=y && GENERIC_HARDIRQS
>>  	select MFD_WM8994
>>  	select SND_SOC_WM8994
> 
> I'm not sure about this since MACH_EXYNOS5_DT can have others instead of SMDK.
> 

But there is no other way we can differentiate between two EXYNOS5_DT
based boards in the kernel. So, support for all possible codecs and
sound-cards should be enabled in the kernel. The instantiation of the
drivers should depend on the device-tree entries.

> Thanks,
> Sangsu.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Tushar Behera

  reply	other threads:[~2012-09-28 10:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 10:29 [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412 Padmavathi Venna
2012-09-28  9:53 ` Sangsu Park
2012-09-28 10:59   ` Tushar Behera [this message]
2012-10-23 11:22     ` Kukjin Kim
2012-10-23 14:54       ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50658325.8050704@linaro.org \
    --to=tushar.behera@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).