* [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412
@ 2012-09-27 10:29 Padmavathi Venna
2012-09-28 9:53 ` Sangsu Park
0 siblings, 1 reply; 5+ messages in thread
From: Padmavathi Venna @ 2012-09-27 10:29 UTC (permalink / raw)
To: linux-arm-kernel
Update Kconfig file to support the Exynos5250 and Exynos4412
Signed-off-by: Sangsu Park <sangsu4u.park@samsung.com>
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
---
sound/soc/samsung/Kconfig | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index fe3995c..430783b 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -1,6 +1,6 @@
config SND_SOC_SAMSUNG
tristate "ASoC support for Samsung"
- depends on ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5PC100 || ARCH_S5PV210 || ARCH_S5P64X0 || ARCH_EXYNOS4
+ depends on PLAT_SAMSUNG
select S3C64XX_DMA if ARCH_S3C64XX
select S3C2410_DMA if ARCH_S3C24XX
help
@@ -63,7 +63,7 @@ config SND_SOC_SAMSUNG_SMDK_WM8580
config SND_SOC_SAMSUNG_SMDK_WM8994
tristate "SoC I2S Audio support for WM8994 on SMDK"
- depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 || MACH_SMDK4212)
+ depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 || MACH_SMDK4212 || MACH_SMDK4412 || MACH_EXYNOS5_DT)
depends on I2C=y && GENERIC_HARDIRQS
select MFD_WM8994
select SND_SOC_WM8994
@@ -162,7 +162,7 @@ config SND_SOC_GONI_AQUILA_WM8994
config SND_SOC_SAMSUNG_SMDK_SPDIF
tristate "SoC S/PDIF Audio support for SMDK"
- depends on SND_SOC_SAMSUNG && (MACH_SMDKC100 || MACH_SMDKC110 || MACH_SMDKV210 || MACH_SMDKV310 || MACH_SMDK4212)
+ depends on SND_SOC_SAMSUNG && (MACH_SMDKC100 || MACH_SMDKC110 || MACH_SMDKV210 || MACH_SMDKV310 || MACH_SMDK4212 || MACH_SMDK4412 || SOC_EXYNOS5250)
select SND_SAMSUNG_SPDIF
help
Say Y if you want to add support for SoC S/PDIF audio on the SMDK.
@@ -177,7 +177,7 @@ config SND_SOC_SMDK_WM8580_PCM
config SND_SOC_SMDK_WM8994_PCM
tristate "SoC PCM Audio support for WM8994 on SMDK"
- depends on SND_SOC_SAMSUNG && (MACH_SMDKC210 || MACH_SMDKV310 || MACH_SMDK4212)
+ depends on SND_SOC_SAMSUNG && (MACH_SMDKC210 || MACH_SMDKV310 || MACH_SMDK4212 || MACH_SMDK4412 || MACH_EXYNOS5_DT)
depends on I2C=y && GENERIC_HARDIRQS
select MFD_WM8994
select SND_SOC_WM8994
--
1.7.4.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412
2012-09-27 10:29 [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412 Padmavathi Venna
@ 2012-09-28 9:53 ` Sangsu Park
2012-09-28 10:59 ` Tushar Behera
0 siblings, 1 reply; 5+ messages in thread
From: Sangsu Park @ 2012-09-28 9:53 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 27, 2012 at 07:30 PM, Padmavathi Venna wrote:
> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
> index fe3995c..430783b 100644
> --- a/sound/soc/samsung/Kconfig
> +++ b/sound/soc/samsung/Kconfig
> @@ -1,6 +1,6 @@
> config SND_SOC_SAMSUNG
> tristate "ASoC support for Samsung"
> - depends on ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5PC100 || ARCH_S5PV210
> || ARCH_S5P64X0 || ARCH_EXYNOS4
> + depends on PLAT_SAMSUNG
> select S3C64XX_DMA if ARCH_S3C64XX
> select S3C2410_DMA if ARCH_S3C24XX
> help
This code is already updated.
> @@ -63,7 +63,7 @@ config SND_SOC_SAMSUNG_SMDK_WM8580
>
> config SND_SOC_SAMSUNG_SMDK_WM8994
> tristate "SoC I2S Audio support for WM8994 on SMDK"
> - depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 ||
> MACH_SMDK4212)
> + depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 ||
> MACH_SMDK4212 || MACH_SMDK4412 || MACH_EXYNOS5_DT)
> depends on I2C=y && GENERIC_HARDIRQS
> select MFD_WM8994
> select SND_SOC_WM8994
I'm not sure about this since MACH_EXYNOS5_DT can have others instead of SMDK.
Thanks,
Sangsu.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412
2012-09-28 9:53 ` Sangsu Park
@ 2012-09-28 10:59 ` Tushar Behera
2012-10-23 11:22 ` Kukjin Kim
0 siblings, 1 reply; 5+ messages in thread
From: Tushar Behera @ 2012-09-28 10:59 UTC (permalink / raw)
To: linux-arm-kernel
On 09/28/2012 03:23 PM, Sangsu Park wrote:
>
> On Thu, Sep 27, 2012 at 07:30 PM, Padmavathi Venna wrote:
>
>> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
>> index fe3995c..430783b 100644
>> --- a/sound/soc/samsung/Kconfig
>> +++ b/sound/soc/samsung/Kconfig
>> @@ -1,6 +1,6 @@
>> config SND_SOC_SAMSUNG
>> tristate "ASoC support for Samsung"
>> - depends on ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5PC100 || ARCH_S5PV210
>> || ARCH_S5P64X0 || ARCH_EXYNOS4
>> + depends on PLAT_SAMSUNG
>> select S3C64XX_DMA if ARCH_S3C64XX
>> select S3C2410_DMA if ARCH_S3C24XX
>> help
>
> This code is already updated.
>
>> @@ -63,7 +63,7 @@ config SND_SOC_SAMSUNG_SMDK_WM8580
>>
>> config SND_SOC_SAMSUNG_SMDK_WM8994
>> tristate "SoC I2S Audio support for WM8994 on SMDK"
>> - depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 ||
>> MACH_SMDK4212)
>> + depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 ||
>> MACH_SMDK4212 || MACH_SMDK4412 || MACH_EXYNOS5_DT)
>> depends on I2C=y && GENERIC_HARDIRQS
>> select MFD_WM8994
>> select SND_SOC_WM8994
>
> I'm not sure about this since MACH_EXYNOS5_DT can have others instead of SMDK.
>
But there is no other way we can differentiate between two EXYNOS5_DT
based boards in the kernel. So, support for all possible codecs and
sound-cards should be enabled in the kernel. The instantiation of the
drivers should depend on the device-tree entries.
> Thanks,
> Sangsu.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Tushar Behera
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412
2012-09-28 10:59 ` Tushar Behera
@ 2012-10-23 11:22 ` Kukjin Kim
2012-10-23 14:54 ` Olof Johansson
0 siblings, 1 reply; 5+ messages in thread
From: Kukjin Kim @ 2012-10-23 11:22 UTC (permalink / raw)
To: linux-arm-kernel
Tushar Behera wrote:
>
> On 09/28/2012 03:23 PM, Sangsu Park wrote:
> >
> > On Thu, Sep 27, 2012 at 07:30 PM, Padmavathi Venna wrote:
> >
[...]
> >> @@ -63,7 +63,7 @@ config SND_SOC_SAMSUNG_SMDK_WM8580
> >>
> >> config SND_SOC_SAMSUNG_SMDK_WM8994
> >> tristate "SoC I2S Audio support for WM8994 on SMDK"
> >> - depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 ||
> >> MACH_SMDK4212)
> >> + depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 ||
> >> MACH_SMDK4212 || MACH_SMDK4412 || MACH_EXYNOS5_DT)
> >> depends on I2C=y && GENERIC_HARDIRQS
> >> select MFD_WM8994
> >> select SND_SOC_WM8994
> >
> > I'm not sure about this since MACH_EXYNOS5_DT can have others instead of
> SMDK.
> >
>
> But there is no other way we can differentiate between two EXYNOS5_DT
> based boards in the kernel. So, support for all possible codecs and
> sound-cards should be enabled in the kernel. The instantiation of the
> drivers should depend on the device-tree entries.
>
Hmm...any idea on this?
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412
2012-10-23 11:22 ` Kukjin Kim
@ 2012-10-23 14:54 ` Olof Johansson
0 siblings, 0 replies; 5+ messages in thread
From: Olof Johansson @ 2012-10-23 14:54 UTC (permalink / raw)
To: linux-arm-kernel
2012/10/23 Kukjin Kim <kgene.kim@samsung.com>:
> Tushar Behera wrote:
>>
>> On 09/28/2012 03:23 PM, Sangsu Park wrote:
>> >
>> > On Thu, Sep 27, 2012 at 07:30 PM, Padmavathi Venna wrote:
>> >
>
> [...]
>
>> >> @@ -63,7 +63,7 @@ config SND_SOC_SAMSUNG_SMDK_WM8580
>> >>
>> >> config SND_SOC_SAMSUNG_SMDK_WM8994
>> >> tristate "SoC I2S Audio support for WM8994 on SMDK"
>> >> - depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 ||
>> >> MACH_SMDK4212)
>> >> + depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210 ||
>> >> MACH_SMDK4212 || MACH_SMDK4412 || MACH_EXYNOS5_DT)
>> >> depends on I2C=y && GENERIC_HARDIRQS
>> >> select MFD_WM8994
>> >> select SND_SOC_WM8994
>> >
>> > I'm not sure about this since MACH_EXYNOS5_DT can have others instead of
>> SMDK.
>> >
>>
>> But there is no other way we can differentiate between two EXYNOS5_DT
>> based boards in the kernel. So, support for all possible codecs and
>> sound-cards should be enabled in the kernel. The instantiation of the
>> drivers should depend on the device-tree entries.
>>
> Hmm...any idea on this?
Tushar is right. In particular, there is absolutely no reason to
enforce driver selection based on platform enablement, as long as it
still builds no matter what (and if it doesn't, that should probably
be fixed).
It should be possible to enable a superset of all drivers, and only
have the ones that are actually instantiated by platform devices or
device tree entries probe and configure. That's how the kernel works
on nearly all platforms.
So, removing as much "depends on" as possible (probably only keep
SND_SOC_SAMSUNG here) seems like a good choice, and fixing any
compilation errors caused by it.
-Olof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-23 14:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-27 10:29 [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412 Padmavathi Venna
2012-09-28 9:53 ` Sangsu Park
2012-09-28 10:59 ` Tushar Behera
2012-10-23 11:22 ` Kukjin Kim
2012-10-23 14:54 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).