linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vipulkumar.samar@st.com (vipul kumar samar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"
Date: Fri, 28 Sep 2012 17:15:53 +0530	[thread overview]
Message-ID: <50658DF1.2000409@st.com> (raw)
In-Reply-To: <1348831266-16721-2-git-send-email-ulf.hansson@stericsson.com>

Hello Ulf,

On 9/28/2012 4:51 PM, Ulf HANSSON wrote:
> From: Ulf Hansson<ulf.hansson@linaro.org>
>
> This reverts commit 6887237cd7da904184dab2750504040c68f3a080.
>
> Signed-off-by: Ulf Hansson<ulf.hansson@linaro.org>
> ---
>   drivers/spi/spi-pl022.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index f8568b4..3f2f36c 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -2188,6 +2188,7 @@ pl022_probe(struct amba_device *adev, const struct amba_id *id)
>   	printk(KERN_INFO "pl022: mapped registers from 0x%08x to %p\n",
>   	       adev->res.start, pl022->virtbase);
>
> +	pm_runtime_enable(dev);

Before calling spi-pl022 probe, amba_probe enables runtime pm. Is it 
requires to re-enable it in spi-pl022 probe??

Regards
Vipul Samar

  reply	other threads:[~2012-09-28 11:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28 11:21 [PATCH 0/3] Fixup use of runtime pm Ulf Hansson
2012-09-28 11:21 ` [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe" Ulf Hansson
2012-09-28 11:45   ` vipul kumar samar [this message]
2012-09-30  8:44   ` Linus Walleij
2012-09-30 10:14     ` Russell King - ARM Linux
2012-09-30 21:43       ` Linus Walleij
2012-10-03 13:43   ` Ulf Hansson
2012-10-03 13:55     ` Mark Brown
2012-10-03 14:28       ` Ulf Hansson
2012-10-03 14:29         ` Mark Brown
2012-09-28 11:21 ` [PATCH 2/3] Revert "spi/pl022: enable runtime PM" Ulf Hansson
2012-09-28 11:50   ` vipul kumar samar
2012-09-30 21:46   ` Linus Walleij
2012-09-28 11:21 ` [PATCH 3/3] spi: spi-pl022: Minor simplification for runtime pm Ulf Hansson
2012-09-30 21:47   ` Linus Walleij
2012-09-28 11:25 ` [PATCH 0/3] Fixup use of " Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50658DF1.2000409@st.com \
    --to=vipulkumar.samar@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).