From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: add new DMA control commands
Date: Thu, 18 Oct 2012 17:10:46 +0800 [thread overview]
Message-ID: <507FC796.7060401@freescale.com> (raw)
In-Reply-To: <20121018085208.GR21164@n2100.arm.linux.org.uk>
? 2012?10?18? 16:52, Russell King - ARM Linux ??:
> On Thu, Oct 18, 2012 at 02:45:41PM +0800, Huang Shijie wrote:
>> ? 2012?10?18? 14:18, Vinod Koul ??:
>>> Why cant you do start (prepare clock etc) when you submit the descriptor
>>> to dmaengine. Can be done in tx_submit callback.
>>> Similarly remove the clock when dma transaction gets completed.
>> I ever thought this method too.
>>
>> But it will become low efficient in the following case:
>>
>> Assuming the gpmi-nand driver has to read out 1024 pages in one
>> _SINGLE_ read operation.
>> The gpmi-nand will submit the descriptor to dmaengine per page. So with
>> your method,
>> the system will repeat the enable/disable dma clock 1024 time. At every
>> enable/disable dma clock,
>> the system has to enable the clock chain and it's parents ...
> And what if you stop using clk_prepare_enable(), and prepare the clock
> when the channel is requested and only use clk_enable() in the tx_submit
yes. it's a little better.
There is nearly no difference between the clk_prepare_enable() and
clk_enable() in actually.
the clk_gate2_ops does not have any @->prepare.
thanks
Huang Shijie
> method?
>
next prev parent reply other threads:[~2012-10-18 9:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 5:32 [PATCH] dma: add new DMA control commands Huang Shijie
2012-10-18 6:18 ` Vinod Koul
2012-10-18 6:45 ` Huang Shijie
2012-10-18 7:14 ` Marek Vasut
2012-10-18 7:49 ` Huang Shijie
2012-10-18 8:16 ` Marek Vasut
2012-10-18 8:29 ` Huang Shijie
2012-11-09 15:29 ` Artem Bityutskiy
2012-10-18 8:49 ` Huang Shijie
2012-10-18 8:49 ` Marek Vasut
2012-10-18 9:13 ` Huang Shijie
2012-10-18 10:51 ` Marek Vasut
2012-10-18 15:11 ` Huang Shijie
2012-10-18 8:52 ` Russell King - ARM Linux
2012-10-18 9:10 ` Huang Shijie [this message]
2012-10-18 9:29 ` Jassi Brar
2012-10-18 15:18 ` Huang Shijie
2012-10-18 15:25 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507FC796.7060401@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).