From: b-cousson@ti.com (Benoit Cousson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio
Date: Thu, 18 Oct 2012 12:00:12 +0200 [thread overview]
Message-ID: <507FD32C.7010108@ti.com> (raw)
In-Reply-To: <1350552307-10226-1-git-send-email-peter.ujfalusi@ti.com>
On 10/18/2012 11:25 AM, Peter Ujfalusi wrote:
> Fixes the following errors:
> [ 2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
> [ 2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel
>
> Which is because we failed to link the sidetone hwmod for McBSP2/3. The
> missing sidetone hwmod link will prevent omap_device_alloc() to append the
> DMA resources since we - accidentally - end up having the same number of
> resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports
> without the ST resources.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Benoit Cousson <b-cousson@ti.com>
Regards,
Benoit
> ---
>
> Hi Tony, Benoit,
>
> Can you please take this patch for 3.7 since if we boot with DT audio will not
> work on BeagleBoard and on boards which uses McBSP2 or 3 for audio.
>
> Thank you,
> Peter
>
> arch/arm/boot/dts/omap3.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index f38ea87..696e929 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -257,7 +257,7 @@
> interrupt-names = "common", "tx", "rx", "sidetone";
> interrupt-parent = <&intc>;
> ti,buffer-size = <1280>;
> - ti,hwmods = "mcbsp2";
> + ti,hwmods = "mcbsp2", "mcbsp2_sidetone";
> };
>
> mcbsp3: mcbsp at 49024000 {
> @@ -272,7 +272,7 @@
> interrupt-names = "common", "tx", "rx", "sidetone";
> interrupt-parent = <&intc>;
> ti,buffer-size = <128>;
> - ti,hwmods = "mcbsp3";
> + ti,hwmods = "mcbsp3", "mcbsp3_sidetone";
> };
>
> mcbsp4: mcbsp at 49026000 {
>
next prev parent reply other threads:[~2012-10-18 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 9:25 [PATCH] ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio Peter Ujfalusi
2012-10-18 10:00 ` Benoit Cousson [this message]
2012-10-22 11:41 ` Péter Ujfalusi
2012-10-22 20:38 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507FD32C.7010108@ti.com \
--to=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).