From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Miles Chen <miles.chen@mediatek.com>
Cc: devicetree@vger.kernel.org, hsinyi@chromium.org,
kewei.xu@mediatek.com, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, qii.wang@mediatek.com,
robh+dt@kernel.org, wsa@kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: convert i2c-mt65xx to json-schema
Date: Thu, 7 Apr 2022 11:45:30 +0200 [thread overview]
Message-ID: <507fd6e4-a425-dbbe-f76f-da90870ff29e@collabora.com> (raw)
In-Reply-To: <20220406232400.2788-1-miles.chen@mediatek.com>
Il 07/04/22 01:24, Miles Chen ha scritto:
> Hi AngeloGioacchino,
>
>> Convert I2C binding for MediaTek SoCs to Devicetree schema.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> .../devicetree/bindings/i2c/i2c-mt65xx.txt | 53 --------
>> .../devicetree/bindings/i2c/i2c-mt65xx.yaml | 118 ++++++++++++++++++
>> MAINTAINERS | 2 +-
>> 3 files changed, 119 insertions(+), 54 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
>> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
>> deleted file mode 100644
>> index 026985b8f61a..000000000000
>> --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
>> +++ /dev/null
..snip..
>> - - clocks: clock name from clock manager
>> - - clock-names: Must include "main" and "dma", "arb" is for multi-master that
>> - one bus has more than two i2c controllers, if enable have-pmic need include
>> - "pmic" extra.
>
>> +
>> + clocks:
>> + minItems: 1
>> + items:
>> + - description: Main clock for I2C bus
>> + - description: Clock for I2C via DMA
>> + - description: Bus arbitrator clock
>> + - description: Clock for I2C from PMIC
>> +
>> + clock-names:
>> + minItems: 1
>> + items:
>> + - const: main
>> + - const: dma
>> + - const: arb
>> + - const: pmic
>
> I read "clock-names: Must include "main" and "dma"" from i2c-mt65xx.txt.
> Does it means that we should have at least 2 clock-names (minItems: 2)?
>
> Thanks,
> Miles
>
Hello Miles,
yes, you're right, I just rechecked the code and this is indeed the case.
Thanks for catching that, will send a v2 shortly.
Regards,
Angelo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-04-07 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 15:29 [PATCH] dt-bindings: i2c: convert i2c-mt65xx to json-schema AngeloGioacchino Del Regno
2022-04-06 23:24 ` Miles Chen
2022-04-07 9:45 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507fd6e4-a425-dbbe-f76f-da90870ff29e@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=kewei.xu@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=qii.wang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).