From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/3] ARM: tegra: move debug-macro.S to include/debug
Date: Thu, 18 Oct 2012 09:15:23 -0500 [thread overview]
Message-ID: <50800EFB.9060503@gmail.com> (raw)
In-Reply-To: <20121018135444.GT21164@n2100.arm.linux.org.uk>
On 10/18/2012 08:54 AM, Russell King - ARM Linux wrote:
> On Thu, Oct 18, 2012 at 08:47:56AM -0500, Rob Herring wrote:
>> Here is what I mentioned previously. This removes the static mapping from
>> the platforms. This is untested and probably breaks on different DEBUG_LL
>> options. For now, platforms call debug_ll_io_init, but once all platforms
>> are converted, this can be called from devicemaps_init.
>
> There's a problem with this approach. What if the platform specifically
> sets the debug addresses to be within one of it's existing mappings (which
> is definitely what you'd want to do with 8250-based UARTs attached to a
> PCI bus.)
>
> This isn't going to work in that case unless we split the debug mapping
> from the PCI IO space mapping.
It is opt-in, so we may never get to the last step. We're still better
off than now. Is there a platform that is doing this? If so, I didn't
move any DEBUG_LL users to the fixed i/o space so they would still be
using their old i/o space address. Having 2 mappings would work, right?
You use the debug mapping initially and when PCI bus and the real
console driver are up, you switch to the fixed i/o space.
This isn't just a PCI issue. You could also have a mapping that covers a
block of SOC peripherals including the uart and you don't want a
separate mapping.
Rob
next prev parent reply other threads:[~2012-10-18 14:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 19:07 [PATCH V2 1/3] ARM: tegra: simplify DEBUG_LL UART selection options Stephen Warren
2012-10-15 19:07 ` [PATCH V2 2/3] ARM: tegra: make debug-macro.S work standalone Stephen Warren
2012-10-15 19:07 ` [PATCH V2 3/3] ARM: tegra: move debug-macro.S to include/debug Stephen Warren
2012-10-17 14:03 ` Arnd Bergmann
2012-10-17 14:38 ` Rob Herring
2012-10-17 16:22 ` Stephen Warren
2012-10-17 21:12 ` Stephen Warren
2012-10-18 9:53 ` Russell King - ARM Linux
2012-10-19 16:37 ` Stephen Warren
2012-10-18 13:47 ` Rob Herring
2012-10-18 13:54 ` Russell King - ARM Linux
2012-10-18 14:15 ` Rob Herring [this message]
2012-10-19 16:40 ` Stephen Warren
2012-10-17 23:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50800EFB.9060503@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).