From: Heiko Stuebner <heiko@sntech.de>
To: Helen Koike <helen.koike@collabora.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Tony Xie <tony.xie@rock-chips.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Randy Li <ayaka@soulik.info>,
linux-kernel@vger.kernel.org, Vicente Bergas <vicencb@gmail.com>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
laurent.pinchart@ideasonboard.com,
manivannan.sadhasivam@linaro.org,
Marc Zyngier <marc.zyngier@arm.com>,
kernel@collabora.com, ezequiel@collabora.com,
linux-arm-kernel@lists.infradead.org,
Christoph Muellner <christoph.muellner@theobroma-systems.com>
Subject: Re: [PATCH] arm64: dts: rockchip: fix isp iommu clocks and power domain
Date: Tue, 04 Jun 2019 15:37:12 +0200 [thread overview]
Message-ID: <5083973.35ftUdt9Su@phil> (raw)
In-Reply-To: <20190603142214.24686-1-helen.koike@collabora.com>
Am Montag, 3. Juni 2019, 16:22:15 CEST schrieb Helen Koike:
> isp iommu requires wrapper variants of the clocks.
> noc variants are always on and using the wrapper variants will activate
> {A,H}CLK_ISP{0,1} due to the hierarchy.
>
> Also add the respective power domain.
>
> Refer:
> RK3399 TRM v1.4 Fig. 2-4 RK3399 Clock Architecture Diagram
> RK3399 TRM v1.4 Fig. 8-1 RK3399 Power Domain Partition
>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
applied for 5.3 with the received Tested-tag and I also moved
parts of the comment into the commit message making it:
"isp iommu requires wrapper variants of the clocks.
noc variants are always on and using the wrapper variants will activate
{A,H}CLK_ISP{0,1} due to the hierarchy.
Tested using the pending isp patch set (which is not upstream
yet). Without this patch, streaming from the isp stalls.
Also add the respective power domain and remove the "disabled" status.
Refer:
RK3399 TRM v1.4 Fig. 2-4 RK3399 Clock Architecture Diagram
RK3399 TRM v1.4 Fig. 8-1 RK3399 Power Domain Partition"
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-06-04 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 14:22 [PATCH] arm64: dts: rockchip: fix isp iommu clocks and power domain Helen Koike
2019-06-03 14:44 ` Ezequiel Garcia
2019-06-03 14:48 ` Manivannan Sadhasivam
2019-06-04 13:37 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5083973.35ftUdt9Su@phil \
--to=heiko@sntech.de \
--cc=ayaka@soulik.info \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=kernel@collabora.com \
--cc=klaus.goger@theobroma-systems.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=robh+dt@kernel.org \
--cc=tony.xie@rock-chips.com \
--cc=vicencb@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).