From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE439C282CE for ; Tue, 4 Jun 2019 13:37:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97B4A233FC for ; Tue, 4 Jun 2019 13:37:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="M2n2hupc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97B4A233FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=goVLhhfiblGFSLliknsgJ/umfLDdt8uGKRlCUmFJE/g=; b=M2n2hupcbZvkeH k+H4mLhGDGSHz2m6OuKHzg9BNU0ArSW2V3+5x4efxaxMMEzPEJjGISg9i+GFfzBMz/xE0Eu9EXyfD xcPnvCkmg5B6iRWSUTVYsXmtgI3ROaf7B0ib0p2vIk+FEBnhjZA9YCFNOKRPaaGr7CTsACVdu79eP +Jndm1FoHSwS2V1C2cUB8aGMxhDliIGVKjXohLUPuRJxuIIRDMGhb+ecz3p+B2s+zs0462P9kqa0z VtNUeZziRuced6zV8Ofvze9IbqxD+dssRy6n3wZ+Fcz1yIg60Ul/CAmI31yk4ptlJZng6XByzhee1 4dcj+kO4hNmhsI/sU0og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY9cu-00017X-S5; Tue, 04 Jun 2019 13:37:20 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY9cr-00015I-5u; Tue, 04 Jun 2019 13:37:18 +0000 Received: from we0305.dip.tu-dresden.de ([141.76.177.49] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hY9cn-0001OW-8E; Tue, 04 Jun 2019 15:37:13 +0200 From: Heiko Stuebner To: Helen Koike Subject: Re: [PATCH] arm64: dts: rockchip: fix isp iommu clocks and power domain Date: Tue, 04 Jun 2019 15:37:12 +0200 Message-ID: <5083973.35ftUdt9Su@phil> In-Reply-To: <20190603142214.24686-1-helen.koike@collabora.com> References: <20190603142214.24686-1-helen.koike@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_063717_365400_44419FCB X-CRM114-Status: GOOD ( 10.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Matthias Brugger , Philipp Tomsich , Tony Xie , Viresh Kumar , Randy Li , linux-kernel@vger.kernel.org, Vicente Bergas , linux-rockchip@lists.infradead.org, Rob Herring , Klaus Goger , laurent.pinchart@ideasonboard.com, manivannan.sadhasivam@linaro.org, Marc Zyngier , kernel@collabora.com, ezequiel@collabora.com, linux-arm-kernel@lists.infradead.org, Christoph Muellner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 3. Juni 2019, 16:22:15 CEST schrieb Helen Koike: > isp iommu requires wrapper variants of the clocks. > noc variants are always on and using the wrapper variants will activate > {A,H}CLK_ISP{0,1} due to the hierarchy. > > Also add the respective power domain. > > Refer: > RK3399 TRM v1.4 Fig. 2-4 RK3399 Clock Architecture Diagram > RK3399 TRM v1.4 Fig. 8-1 RK3399 Power Domain Partition > > Signed-off-by: Helen Koike applied for 5.3 with the received Tested-tag and I also moved parts of the comment into the commit message making it: "isp iommu requires wrapper variants of the clocks. noc variants are always on and using the wrapper variants will activate {A,H}CLK_ISP{0,1} due to the hierarchy. Tested using the pending isp patch set (which is not upstream yet). Without this patch, streaming from the isp stalls. Also add the respective power domain and remove the "disabled" status. Refer: RK3399 TRM v1.4 Fig. 2-4 RK3399 Clock Architecture Diagram RK3399 TRM v1.4 Fig. 8-1 RK3399 Power Domain Partition" Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel