From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc
Date: Tue, 23 Oct 2012 18:04:53 +0530 [thread overview]
Message-ID: <50868EED.7050909@ti.com> (raw)
In-Reply-To: <1349702227-24875-1-git-send-email-const@MakeLinux.com>
On 10/8/2012 6:47 PM, Constantine Shulyupin wrote:
> From: Constantine Shulyupin <const@MakeLinux.com>
>
> Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly
> CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST
> and set MUSB_OTG configuration by default
> because this configuration options are removed from Kconfig.
>
> Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
Queuing this patch for v3.8. Since the config options are removed there
is no use having code which refers to them. The patch has been tested on
DM644x and DM365 in both host and gadget mode (I will add this
information to commit text while committing). Without this patch .mode
seems to be defaulting to MUSB_UNDEFINED which I think is definitely wrong.
Thanks,
Sekhar
>
> ---
> arch/arm/mach-davinci/usb.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c
> index f77b953..34509ff 100644
> --- a/arch/arm/mach-davinci/usb.c
> +++ b/arch/arm/mach-davinci/usb.c
> @@ -42,14 +42,8 @@ static struct musb_hdrc_config musb_config = {
> };
>
> static struct musb_hdrc_platform_data usb_data = {
> -#if defined(CONFIG_USB_MUSB_OTG)
> /* OTG requires a Mini-AB connector */
> .mode = MUSB_OTG,
> -#elif defined(CONFIG_USB_MUSB_PERIPHERAL)
> - .mode = MUSB_PERIPHERAL,
> -#elif defined(CONFIG_USB_MUSB_HOST)
> - .mode = MUSB_HOST,
> -#endif
> .clock = "usb",
> .config = &musb_config,
> };
>
next prev parent reply other threads:[~2012-10-23 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 13:17 [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc Constantine Shulyupin
2012-10-11 5:42 ` Manjunathappa, Prakash
2012-10-11 6:35 ` Heiko Schocher
2012-10-11 8:50 ` Sekhar Nori
2012-10-11 10:06 ` Constantine Shulyupin
2012-10-23 12:34 ` Sekhar Nori [this message]
2012-10-23 12:39 ` Felipe Balbi
2012-10-24 11:10 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50868EED.7050909@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).