From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth) Date: Sun, 28 Oct 2012 22:42:52 +0100 Subject: [PATCH V3 1/3] clk: mvebu: add armada-370-xp specific clocks In-Reply-To: <1350303499-30868-2-git-send-email-gregory.clement@free-electrons.com> References: <1350303499-30868-1-git-send-email-gregory.clement@free-electrons.com> <1350303499-30868-2-git-send-email-gregory.clement@free-electrons.com> Message-ID: <508DA6DC.4070601@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/15/2012 02:18 PM, Gregory CLEMENT wrote: > Add Armada 370/XP specific clocks: core clocks and CPU clocks. > > The CPU clocks are only for Armada XP for the SMP mode. > > ... > +static struct core_clk_fn armada_370_clk_fn = { > + .get_tclk_freq = armada_370_get_tclk_freq, > + .get_pck_freq = armada_370_get_pck_freq, > + .get_fab_freq_opt = armada_370_get_fab_freq_opt, > +}; > + > +static struct core_clk_fn armada_xp_clk_fn = { > + .get_tclk_freq = armada_xp_get_tclk_freq, > + .get_pck_freq = armada_xp_get_pck_freq, > + .get_fab_freq_opt = armada_xp_get_fab_freq_opt, > +}; > + > +static const __initconst struct of_device_id clk_match[] = { > + { > + .compatible = "marvell,armada-370-core-clockctrl", > + .data =&armada_370_clk_fn, > + }, > + > + { > + .compatible = "marvell,armada-xp-core-clockctrl", > + .data =&armada_xp_clk_fn, > + }, > + { > + /* sentinel */ > + } > +}; Gregory, armada_370_clk_fn and armada_xp_clk_fn cause section mismatches as they are referenced within __initconst. You should either rename them to armada_xp_clk_ops or annotate them with the appropriate attribute. Sebastian