* [PATCH] ARM: highbank: retry wfi on reset request
@ 2012-10-26 3:20 Rob Herring
2012-10-29 17:22 ` Rob Herring
2012-11-06 14:55 ` Olof Johansson
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2012-10-26 3:20 UTC (permalink / raw)
To: linux-arm-kernel
From: Rob Herring <rob.herring@calxeda.com>
In some cases, an interrupt can occur and prevent cause failure to enter
wfi. This causes reset to hang. Retrying the wfi should be enough to
prevent reset from hanging.
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
arch/arm/mach-highbank/system.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-highbank/system.c b/arch/arm/mach-highbank/system.c
index 82c2723..86e37cd 100644
--- a/arch/arm/mach-highbank/system.c
+++ b/arch/arm/mach-highbank/system.c
@@ -28,6 +28,7 @@ void highbank_restart(char mode, const char *cmd)
hignbank_set_pwr_soft_reset();
scu_power_mode(scu_base_addr, SCU_PM_POWEROFF);
- cpu_do_idle();
+ while (1)
+ cpu_do_idle();
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: highbank: retry wfi on reset request
2012-10-26 3:20 [PATCH] ARM: highbank: retry wfi on reset request Rob Herring
@ 2012-10-29 17:22 ` Rob Herring
2012-11-06 14:55 ` Olof Johansson
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2012-10-29 17:22 UTC (permalink / raw)
To: linux-arm-kernel
On 10/25/2012 10:20 PM, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> In some cases, an interrupt can occur and prevent cause failure to enter
> wfi. This causes reset to hang. Retrying the wfi should be enough to
> prevent reset from hanging.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> ---
Arnd, Olof,
Can you please apply this for 3.7?
Rob
> arch/arm/mach-highbank/system.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-highbank/system.c b/arch/arm/mach-highbank/system.c
> index 82c2723..86e37cd 100644
> --- a/arch/arm/mach-highbank/system.c
> +++ b/arch/arm/mach-highbank/system.c
> @@ -28,6 +28,7 @@ void highbank_restart(char mode, const char *cmd)
> hignbank_set_pwr_soft_reset();
>
> scu_power_mode(scu_base_addr, SCU_PM_POWEROFF);
> - cpu_do_idle();
> + while (1)
> + cpu_do_idle();
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: highbank: retry wfi on reset request
2012-10-26 3:20 [PATCH] ARM: highbank: retry wfi on reset request Rob Herring
2012-10-29 17:22 ` Rob Herring
@ 2012-11-06 14:55 ` Olof Johansson
1 sibling, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2012-11-06 14:55 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 25, 2012 at 10:20:37PM -0500, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> In some cases, an interrupt can occur and prevent cause failure to enter
> wfi. This causes reset to hang. Retrying the wfi should be enough to
> prevent reset from hanging.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Applied, thanks.
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-06 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-26 3:20 [PATCH] ARM: highbank: retry wfi on reset request Rob Herring
2012-10-29 17:22 ` Rob Herring
2012-11-06 14:55 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).