From: shubhrajyoti@ti.com (Shubhrajyoti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] i2c: omap: Fix the revision register read
Date: Wed, 31 Oct 2012 16:28:38 +0530 [thread overview]
Message-ID: <5091045E.8040407@ti.com> (raw)
In-Reply-To: <20121031101201.GB10094@arwen.pp.htv.fi>
On Wednesday 31 October 2012 03:42 PM, Felipe Balbi wrote:
>>
>> > + if (!_dev->regs)
>> > + return 0;
> this is wrong, you need to make sure dev->regs is set early enough.
to set the dev->regs I use the value read from revision register.
to read the revision register I do a get_sync first. This in turn leads
to the call to resume handler.
At this point the regs is NULL and so the check.
After reading the register and checking the scheme bit.
the reg map is populated.
How can this issue be solved?
next prev parent reply other threads:[~2012-10-31 10:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 8:59 [PATCH RFC] i2c: omap: Fix the revision register read Shubhrajyoti D
2012-10-31 9:32 ` Shubhrajyoti Datta
2012-10-31 10:12 ` Felipe Balbi
2012-10-31 10:12 ` Felipe Balbi
2012-10-31 10:48 ` Shubhrajyoti
2012-10-31 11:52 ` Felipe Balbi
2012-10-31 10:58 ` Shubhrajyoti [this message]
2012-10-31 11:52 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5091045E.8040407@ti.com \
--to=shubhrajyoti@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).