From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 3/4] ARM: tegra: dts: cardhu: enable SLINK4
Date: Wed, 31 Oct 2012 10:44:19 -0600 [thread overview]
Message-ID: <50915563.40904@wwwdotorg.org> (raw)
In-Reply-To: <1351674176-20603-3-git-send-email-ldewangan@nvidia.com>
On 10/31/2012 03:02 AM, Laxman Dewangan wrote:
> Enable SLINK4 and connected device in Tegra30 based
> platform Cardhu.
> Setting maximum spi frequency to 25MHz.
>
> Spi serial flash is connected on CS1 of SLINK4 on
> cardhu platform.
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> +winbond Winbond Electronics corp.
That should really be a separate patch that goes through the devicetree
branch. But I guess it's fairly trivial, so it's not a big deal.
> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> + spi-flash at 1 {
> + compatible = "winbond,w25q32";
> + spi-max-frequency = <20000000>;
> + reg = <1>;
> + };
Since I have an Atmel flash on my board, I see:
[ 1.282958] m25p80 spi32766.1: found at25df321a, expected w25q32
[ 1.289103] m25p80 spi32766.1: at25df321a (4096 Kbytes)
Is there any way around that (the first log line above)?
I suppose the answer is that the DT should reflect the exact flash
device that's on the board, and perhaps the bootloader should be
adjusting the DT to reflect the correct value. That's probably complex.
Do you have any idea whether Atmel or Winbond flash is more common, so
we can at least minimize the number of times this message appears?
next prev parent reply other threads:[~2012-10-31 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 9:02 [PATCH V4 0/4] ARM: tegra: Enable SLINK controller driver Laxman Dewangan
2012-10-31 9:02 ` [PATCH V4 2/4] ARM: tegra: Add OF_DEV_AUXDATA for SLINK driver in board dt Laxman Dewangan
2012-10-31 9:02 ` [PATCH V4 3/4] ARM: tegra: dts: cardhu: enable SLINK4 Laxman Dewangan
2012-10-31 16:44 ` Stephen Warren [this message]
2012-10-31 17:39 ` Laxman Dewangan
2012-10-31 9:02 ` [PATCH V4 4/4] ARM: tegra: config: enable spi driver for Tegra SLINK controller Laxman Dewangan
2012-10-31 9:02 ` [PATCH V4 0/4] ARM: tegra: Enable SLINK controller driver Laxman Dewangan
2012-10-31 16:29 ` Stephen Warren
2012-10-31 17:31 ` Laxman Dewangan
2012-10-31 19:16 ` Stephen Warren
2012-11-01 3:45 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50915563.40904@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).