From: ludovic.desroches@atmel.com (ludovic.desroches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: at91: add a sanity check on i2c message length
Date: Fri, 2 Nov 2012 12:04:45 +0100 [thread overview]
Message-ID: <5093A8CD.60006@atmel.com> (raw)
In-Reply-To: <20121101222922.GD22956@pengutronix.de>
Hi Wolfram,
Le 11/01/2012 11:29 PM, Wolfram Sang a ?crit :
> On Wed, Oct 10, 2012 at 04:25:58PM +0200, ludovic.desroches at atmel.com wrote:
>> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>>
>> If the i2c message length is zero, i2c-at91 will directly return an error
>> instead of trying to send a zero-length message.
>>
>> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
>
> What happens if you send a 0 byte message? Some hardware is able to do
> this and it will be used in SMBUS QUICK which the driver states to
> support according to at91_twi_func().
Without this I had some data corruption when writing to / reading from a
serial eeprom (depending on the IP version).
Yes SMBUS quick command is supported but is not managed in the driver,
we have to tell explicitly the IP that we want to send this command.
Regards
Ludovic
>
> Regards,
>
> Wolfram
>
next prev parent reply other threads:[~2012-11-02 11:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 14:25 [PATCH] i2c: at91: add a sanity check on i2c message length ludovic.desroches at atmel.com
2012-10-24 14:34 ` ludovic.desroches
2012-11-01 22:29 ` Wolfram Sang
2012-11-02 11:04 ` ludovic.desroches [this message]
2012-11-02 11:14 ` Wolfram Sang
2012-11-02 16:00 ` ludovic.desroches
2012-11-03 14:16 ` Wolfram Sang
2012-11-05 6:08 ` Voss, Nikolaus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5093A8CD.60006@atmel.com \
--to=ludovic.desroches@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).