From: smuckle@codeaurora.org (Steve Muckle)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: idle sleep time for hotplugged cpu
Date: Tue, 06 Nov 2012 12:24:20 -0800 [thread overview]
Message-ID: <509971F4.4060604@codeaurora.org> (raw)
In-Reply-To: <20121105091533.GB28327@n2100.arm.linux.org.uk>
On 11/05/12 01:15, Russell King - ARM Linux wrote:
> On Mon, Nov 05, 2012 at 09:23:38AM +0530, Taniya Das wrote:
>> I was looking at the arch/arm/process.c:cpu_die, I was wondering why we
>> do not exit from NOHZ for a hotplugged/offline cpu?
>
> Offlined CPUs are not supposed to just 'return' from cpu_die(), and
> in actual fact they can't.
Although an offline CPU will not come back into the idle thread by
returning from cpu_die(), I believe the question about exiting nohz mode
before cpu_die() still stands.
>From arch/arm/process.c:cpu_idle() it appears a CPU could enter
pm_idle() for a while (in nohz mode), then execute the inner loop again
and call cpu_die(). Is there the potential for cpu idle time accounting
to get messed up here by not exiting nohz mode prior to the cpu dying,
so that missed ticks from nohz are properly accounted for?
thanks,
Steve
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2012-11-06 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 3:53 ARM: idle sleep time for hotplugged cpu Taniya Das
2012-11-05 9:15 ` Russell King - ARM Linux
2012-11-06 20:24 ` Steve Muckle [this message]
2012-11-06 21:00 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509971F4.4060604@codeaurora.org \
--to=smuckle@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).