From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B171C761A6 for ; Mon, 3 Apr 2023 07:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qtFIYo7A6xa7GLGfjPpLJE7o6vOIt75K/tIUBNhM4Fs=; b=oElpJCQdfrqcDt T0QZxZWmy0y9bYLXSIbHJ0ic42HW6ElQ/0AMzYb0xzIN3MsBimSCUbYZxDmY1EYwS38ayVKc2RwBc qjAIMeZaGF7HPX+dhYecchKDAkvASvHS1R3/TwHxOG/Z48I6ENIOxO7o1yZqAoCorhvRwLL8jK1Ah IBZ3Q2+zmNdhK38Dk9yLa140qQUXCPmwDoHCWbPbJlKHWK7zT7ixfS3apWDfAuIx+TlGGMZXEpKE4 IGR9ft4JSFxc50zqHtUMLL3vr1DpX15hHXCgbfxODx6scr42UPjGg9B7kH3wt5DH+veNpc9lLuRLU 5LoIUDYH7VD4h+Y2F/Aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjEvn-00ER41-1C; Mon, 03 Apr 2023 07:48:47 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjEvk-00ER2o-1T for linux-arm-kernel@lists.infradead.org; Mon, 03 Apr 2023 07:48:46 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3336VYA2031952; Mon, 3 Apr 2023 09:48:29 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=lbrDY8Ppljv7KIzDAhEp83EYJqZkiErv5p1W4oG7g5k=; b=PM/TjdUTTRv7HcYJYnvyYOweQIo3jLh3k9NJFkAB/TU53eldc3KtqlJn2GA/vcU9x4Hr lFX2bQ64LeKl8TT0frZPCFoMUgYmp3uaEDwqkL6JDbP9IGaMONiQbZe5kmvZ9/KdXzNG oZfzCJ69+8DyX5+wrFBNb+/ehOkzUqrf2DidTOTGFW4qsk4ZBp8WcMTYBUFwE2eHam3/ DAen+x9N5TUv2ncdxTG+aCjfzpFRwtvV5fkiabI9EpKDCRizZv9rwfDkIsgfLDpERtgz d7oplG72nWe8hzUy12lFw7Ctz1PKmj8ZrNqVnz7nWgHi30CVRLAryy63/4E9aQjkPMhG jw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3ppbgm11ev-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Apr 2023 09:48:29 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3109010002A; Mon, 3 Apr 2023 09:48:28 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 2AD5B2122F3; Mon, 3 Apr 2023 09:48:28 +0200 (CEST) Received: from [10.201.21.93] (10.201.21.93) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 3 Apr 2023 09:48:27 +0200 Message-ID: <509b45f9-b6f1-d6a1-c76f-1047efc2334c@foss.st.com> Date: Mon, 3 Apr 2023 09:48:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1] ARM: dts: stm32: prtt1c: Add PoDL PSE regulator nodes Content-Language: en-US To: Oleksij Rempel CC: Maxime Coquelin , Rob Herring , Krzysztof Kozlowski , =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= , , , , , , References: <20230323123242.3763673-1-o.rempel@pengutronix.de> <1a2d16c8-8c16-5fcc-7906-7b454a81922f@foss.st.com> <20230328110247.GE15196@pengutronix.de> From: Alexandre TORGUE In-Reply-To: <20230328110247.GE15196@pengutronix.de> X-Originating-IP: [10.201.21.93] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-03_04,2023-03-31_01,2023-02-09_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230403_004844_800520_0201EB66 X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Oleksij On 3/28/23 13:02, Oleksij Rempel wrote: > On Tue, Mar 28, 2023 at 11:58:34AM +0200, Alexandre TORGUE wrote: >> Hi Oleksij >> >> On 3/23/23 13:32, Oleksij Rempel wrote: >>> This commit introduces Power over Data Line (PoDL) Power Source >>> Equipment (PSE) regulator nodes to the PRTT1C devicetree. The addition >>> of these nodes enables support for PoDL in PRTT1C devices, allowing >>> power delivery and data transmission over a single twisted pair. >>> >>> The new PoDL PSE regulator nodes provide voltage capability information >>> of the current board design, which can be used as a hint for system >>> administrators when configuring and managing power settings. This >>> update enhances the versatility and simplifies the power management of >>> PRTT1C devices while ensuring compatibility with connected Powered >>> Devices (PDs). >>> >>> After applying this patch, the power delivery can be controlled from >>> user space with a patched [1] ethtool version using the following commands: >>> ethtool --set-pse t1l2 podl-pse-admin-control enable >>> to enable power delivery, and >>> ethtool --show-pse t1l2 >>> to display the PoDL PSE settings. >>> >>> By integrating PoDL PSE support into the PRTT1C devicetree, users can >>> benefit from streamlined power and data connections in their >>> deployments, improving overall system efficiency and reducing cabling >>> complexity. >>> >>> [1] https://lore.kernel.org/all/20230317093024.1051999-1-o.rempel@pengutronix.de/ >>> >>> Signed-off-by: Oleksij Rempel >>> --- >> >> Please, fix the introduction of those new yaml validation errors: >> >> arch/arm/boot/dts/stm32mp151a-prtt1c.dtb: ethernet-pse-1: $nodename:0: >> 'ethernet-pse-1' does not match '^ethernet-pse(@.*)?$' >> From schema: >> /Documentation/devicetree/bindings/net/pse-pd/podl-pse-regulator.yaml >> arch/arm/boot/dts/stm32mp151a-prtt1c.dtb: ethernet-pse-2: $nodename:0: >> 'ethernet-pse-2' does not match '^ethernet-pse(@.*)?$' >> From schema: /local/home/frq08678/STLINUX/kernel/my-kernel/stm32/Documentation/devicetree/bindings/net/pse-pd/podl-pse-regulator.yaml > > Using ethernet-pse@1 will require to use "reg" or "ranges" properties. > Which makes no sense in this use case. I need to fix the schema instead by > allowing this patter with following regex: "^ethernet-pse(@.*|-[0-9a-f])*$" > > Should I send schema fix together with this patch? Yes you can. As soon as Rob or Krzysztof review it I'll apply both on stm32-next. Thanks Alex > Regards, > Oleksij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel