From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CC57C7EE22 for ; Wed, 17 May 2023 23:45:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jZmNsuYTnctVgy9QzsoZ5oISy5W/62+8slQPLHq0Jso=; b=bKCYneUYTbB6KRnCPWzEtqQAA9 iJrNqBKKL3rnI2szfM+5ExgzU5pjzzgBFEQ5gTypjO7zH5d00UW02dnSjfSW/fmx6t3Nc+HX7vJTR Sw8N1tYK+p5RaRpbg1/gKKM43cAu8ifaoLP8mbX/s1e8l0ArEfRIHeA62ODUwjSLJPnwDnKOFIu58 S9Y/yphuvIZJRuepljj3qVJJcwyyKJxKanEMBPB7vmlmL7Uo5Yr9CLwtyzcX8aLsJakDVcTjaalFa qg3f0lrx6LYRw8Ye/NlpTCL8DDNCIYnsiR/YiNwSibLv4Y1tHM9rsrtDn0iyDjUi2gsHsjWz28omr s83as8lQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzQpW-00BOi1-2T; Wed, 17 May 2023 23:45:14 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzQpU-00BOh1-0O for linux-arm-kernel@lists.infradead.org; Wed, 17 May 2023 23:45:13 +0000 Received: from mail.denx.de (unknown [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: festevam@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2074E84768; Thu, 18 May 2023 01:45:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1684367109; bh=dL0+UeJibxu8mzGrndHBRMbTCz4acRDAzM78ya9TO88=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=B1IzQh0rG5rT6iXLxuG2LRuF0nH0FMdQrjSNrMKYkRKl13f7GS/mbksan+FvlYNO+ Pn//XYyKCmgWEHRUmqfXtotfXanK1iiKLipDyfu5n+vfsxxackZ5sCwGGhkSq88uDh ExfQ9a0xxMKGT5CnTqg2K7ax7+oibOMzL9GjgRmiOxGKYuZgjY0QG/MyBSMjY67ETi mpU65Mpk2AXrcXQeec/0QDKQmmPWEiuiV6QRXVQxhhUaS3HSIlN0a/CXfSGKyCJyfl PmPq41C0KEqNG7jZpoar7zS/N/SS7pT/cSLHLr3LFMiM2Nq5b94Q6i+nurLZkJtEFz WNF8sRz/cRbJw== MIME-Version: 1.0 Date: Wed, 17 May 2023 20:45:09 -0300 From: Fabio Estevam To: Marek Vasut Cc: Fabio Estevam , shawnguo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: dts: imx6sx: Add LDB support In-Reply-To: <16ecb29a-4d52-9464-ecb0-2e45262af105@denx.de> References: <20230517210210.12183-1-festevam@gmail.com> <16ecb29a-4d52-9464-ecb0-2e45262af105@denx.de> Message-ID: <509c272d28cf3e6f642115fb424e51bc@denx.de> X-Sender: festevam@denx.de User-Agent: Roundcube Webmail/1.3.6 X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230517_164512_330834_1EDB4B1D X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, On 17/05/2023 20:15, Marek Vasut wrote: >> diff --git a/arch/arm/boot/dts/imx6sx.dtsi >> b/arch/arm/boot/dts/imx6sx.dtsi >> index 4233943a1cca..7a8a00d81666 100644 >> --- a/arch/arm/boot/dts/imx6sx.dtsi >> +++ b/arch/arm/boot/dts/imx6sx.dtsi >> @@ -843,8 +843,39 @@ iomuxc: pinctrl@20e0000 { >> gpr: iomuxc-gpr@20e4000 { >> compatible = "fsl,imx6sx-iomuxc-gpr", >> - "fsl,imx6q-iomuxc-gpr", "syscon"; >> + "fsl,imx6q-iomuxc-gpr", "simple-bus", "syscon"; > > Can we really combine simple-bus and syscon or do we need something > like Thanks for your review. > 5a51e1f2b0834 ("arm64: dts: imx8mp: Drop simple-bus from > fsl,imx8mp-media-blk-ctrl") As is, if simple-bus is dropped, the LDB bus is not probed. > 9cb6d1b39a8f5 ("soc: imx: imx8m-blk-ctrl: Scan subnodes and bind > drivers to them") On the i.MX6SX, I am not sure we can add devm_of_platform_populate() like in the imx8m-blk-ctrl case. imx8m-blk-ctrl has a probe function, but imx6q-iomuxc-gpr does not. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel