From: csd@broadcom.com (Christian Daudt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] Add support for generic BCM SoC chipsets
Date: Tue, 13 Nov 2012 09:58:13 -0800 [thread overview]
Message-ID: <50A28A35.8090003@broadcom.com> (raw)
In-Reply-To: <20121112151720.GG28327@n2100.arm.linux.org.uk>
On 12-11-12 07:17 AM, Russell King - ARM Linux wrote:
> On Sun, Nov 11, 2012 at 06:57:14AM -0800, Christian Daudt wrote:
>> +#include <linux/of_irq.h>
>> +#include <linux/of_platform.h>
>> +#include <linux/init.h>
>> +#include <linux/device.h>
>> +#include <linux/platform_device.h>
>> +#include <asm/io.h>
> Please use linux/io.h rather than asm/io.h throughout your patch sets.
> However, I don't see anything in this file which requires this header,
> so it's better off being removed entirely.
>
that will be required later, but you're right. It is not being used at
this point so I've removed it.
thanks,
csd
next prev parent reply other threads:[~2012-11-13 17:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 14:57 [PATCH v2] Add support for generic BCM SoC chipsets Christian Daudt
2012-11-11 15:53 ` Florian Fainelli
2012-11-11 17:32 ` Christian Daudt
2012-11-11 18:43 ` Florian Fainelli
2012-11-11 21:40 ` Stephen Warren
2012-11-12 15:00 ` Arnd Bergmann
2012-11-12 16:04 ` Domenico Andreoli
2012-11-12 17:05 ` Arnd Bergmann
2012-11-12 17:15 ` Stephen Warren
2012-11-13 17:53 ` Christian Daudt
2012-11-13 21:31 ` Domenico Andreoli
2012-11-12 15:17 ` Russell King - ARM Linux
2012-11-13 17:58 ` Christian Daudt [this message]
2012-11-13 4:45 ` Stephen Warren
2012-11-13 19:02 ` Christian Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A28A35.8090003@broadcom.com \
--to=csd@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).