From: mikedunn@newsguy.com (Mike Dunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] MTD: at91: atmel_nand: return bit flips for the PMECC read_page()
Date: Tue, 27 Nov 2012 10:59:13 -0800 [thread overview]
Message-ID: <50B50D81.3060401@newsguy.com> (raw)
In-Reply-To: <1354013431-13598-1-git-send-email-josh.wu@atmel.com>
On 11/27/2012 02:50 AM, Josh Wu wrote:
> This patch fix pmecc's read_page() to return maximum number of bitflips, 0 if uncorrectable.
>
> In the commit: 3f91e94f7f511de74c0d2abe08672ccdbdd1961c ("mtd: nand: read_page() returns max_bitflips ()"),
> The ecc.read_page() is changed to return the maximum number of bitflips.
> And when meet uncorrectable bitflips it needs to return 0.
>
> See the comment in nand.h:
> * @read_page: function to read a page according to the ECC generator
> * requirements; returns maximum number of bitflips corrected in
> * any single ECC step, 0 if bitflips uncorrectable, -EIO hw error
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> change since v1:
> 1. add detail commit message for the fix.
> 2. return 0 when meet uncorrectable bitflips according to Mike Dunn's suggestion.
Reviewed-by: Mike Dunn <mikedunn@newsguy.com>
I see now the pmecc controller patch in the git log. Nice work.
Mike
next prev parent reply other threads:[~2012-11-27 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 10:50 [PATCH v2] MTD: at91: atmel_nand: return bit flips for the PMECC read_page() Josh Wu
2012-11-27 18:59 ` Mike Dunn [this message]
2012-11-27 19:35 ` Mike Dunn
2012-11-29 7:45 ` Josh Wu
2012-11-29 17:20 ` Mike Dunn
2012-12-03 14:35 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B50D81.3060401@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox